[v11] 3. Remove obsolete WriteAsync overloads #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
changed the title
Pull Request Test Coverage Report for Build 4224398269
💛 - Coveralls |
LaPeste
approved these changes
Feb 16, 2023
| @@ -575,7 +575,8 @@ public void UsingDisposedRealm_ShouldThrowObjectDisposedException() | |||
| Assert.That(() => realm.RemoveAll<Person>(), Throws.TypeOf<ObjectDisposedException>()); | |||
| Assert.That(() => realm.Write(() => { }), Throws.TypeOf<ObjectDisposedException>()); | |||
|
|
|||
| await TestHelpers.AssertThrows<ObjectDisposedException>(() => realm.WriteAsync(_ => { })); | |||
| await TestHelpers.AssertThrows<ObjectDisposedException>(() => realm.WriteAsync(() => { })); | |||
| await TestHelpers.AssertThrows<ObjectDisposedException>(() => realm.RefreshAsync()); | |||
There was a problem hiding this comment.
I guess this should have been here since the beginning. Correct?
nirinchev
changed the title
nirinchev
force-pushed
the
ni/v11-dynamic
branch
from
d6b3316 to
5821960
Compare
nirinchev
force-pushed
the
ni/v11-async-write
branch
from
c739c98 to
08363a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes old
WriteAsync(Action<Realm>)in favor ofWriteAsync(Action).TODO