Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack around Unity editor API change #3307

Merged
merged 4 commits into from
May 5, 2023
Merged

Hack around Unity editor API change #3307

merged 4 commits into from
May 5, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented May 4, 2023 •
edited
Loading

Description

Fixes #3306

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label May 4, 2023
@nirinchev nirinchev marked this pull request as ready for review May 4, 2023 15:34
@nirinchev nirinchev requested a review from fealebenpae May 4, 2023 16:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4885418588

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.876%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Extensions/TaskExtensions.cs 1 68.09%
Realm/Realm/Exceptions/RealmException.cs 2 78.38%
Realm/Realm/Handles/SessionHandle.cs 3 84.26%
Realm/Realm/Handles/SubscriptionSetHandle.cs 3 95.41%
Totals Coverage Status
Change from base Build 4862606330: -0.1%
Covered Lines: 5875
Relevant Lines: 7043
💛 - Coveralls

@nirinchev nirinchev merged commit 86090c4 into main May 5, 2023
@nirinchev nirinchev deleted the ni/unity-2022 branch May 5, 2023 18:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae Awaiting requested review from fealebenpae

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unity] RealmWeaver PostBuild step doesn't work in Unity 2022
2 participants
@nirinchev @coveralls