Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of reg invocations on Unity #3365

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jun 27, 2023

Description

This PR attempts to address the issues highlighted in #3364 by:

  1. Creating a hidden window for the reg invocation. This should address the annoyance of a terminal window popping up every time we build the project.
  2. Caching the results of the reg invocation. Those are unlikely to change, so no need to run it on every build.

Fixes #3364

TODO

  • Changelog entry
  • Tests (if applicable)
  • Decide whether we want to keep getting the machine guid from reg or use one of the Unity options for a unique device id.

@nirinchev nirinchev marked this pull request as ready for review July 7, 2023 11:14
@nirinchev nirinchev merged commit c1186dd into main Jul 7, 2023
@nirinchev nirinchev deleted the ni/analytics-fixes branch July 7, 2023 11:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmWeaver: Excessive amount of reg.exe subprocesses and occasional weaving error
1 participant