Fix a race between canceling async transaction and Realm.Dispose #3400
+69
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jul 26, 2023
| // return false and we must ignore the cancel request (and let Core proceed with the transaction). This is because | ||
| // if we canceled the transaction here, the caller would free the tcs GCHandle while at the same time an async transaction | ||
| // would be ongoing which will eventually attempt to use the tcs through the GCHandle, resulting in a hard crash on Mono. | ||
| if (!IsClosed && |
There was a problem hiding this comment.
This is the fix for issue 1.
| @@ -748,6 +748,8 @@ public async Task<bool> RefreshAsync() | |||
| try | |||
| { | |||
| var didRegister = NativeMethods.refresh_async(this, GCHandle.ToIntPtr(tcsHandle), out var ex); | |||
| ex.ThrowIfNecessary(); | |||
There was a problem hiding this comment.
This is the fix for issue 2.
papafe
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saw that in a CI run: https://github.com/realm/realm-dotnet/actions/runs/5671307649/job/15368851506
Also adds a missing
ex.ThrowIfNecessary()inRefreshAsync.The rest of the changes are primarily cosmetic addressing some local member shadowing which was irritating me and the IDE.
TODO