Added test for findAll searching for String and Long (issue #16).

realm · May 23, 2012 · a0ace99 · a0ace99
1 parent 66e7d0b
commit a0ace99
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/src/main/java/com/tightdb/lib/AbstractColumn.java b/src/main/java/com/tightdb/lib/AbstractColumn.java
@@ -81,7 +81,7 @@ protected Query query(TableQuery tableQuery) {
 	}
 
 	protected Cursor cursor(long position) {
-		return position >= 0 ? AbstractCursor.createCursor(types.getCursorClass(), rowset, position) : null;
+		return (position >= 0 && position < rowset.size()) ? AbstractCursor.createCursor(types.getCursorClass(), rowset, position) : null;
 	}
 
 	protected View view(TableViewBase viewBase) {

diff --git a/src/test/java/com/tightdb/lib/TableTest.java b/src/test/java/com/tightdb/lib/TableTest.java
@@ -1,6 +1,7 @@
 package com.tightdb.lib;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 import java.util.Date;
 
@@ -9,6 +10,7 @@
 
 import com.tightdb.generated.Employee;
 import com.tightdb.generated.EmployeeTable;
+import com.tightdb.generated.EmployeeView;
 
 public class TableTest {
 
@@ -23,7 +25,7 @@ public void init() {
 		employees = new EmployeeTable();
 
 		employees.add(NAME0, "Doe", 10000, true, new byte[] { 1, 2, 3 }, new Date(), "extra");
-		employees.add(NAME2, "B. Good", 20000, true, new byte[] { 1, 2, 3 }, new Date(), true);
+		employees.add(NAME2, "B. Good", 10000, true, new byte[] { 1, 2, 3 }, new Date(), true);
 		employees.insert(1, NAME1, "Mihajlovski", 30000, false, new byte[] { 4, 5 }, new Date(), 1234);
 	}
 
@@ -69,9 +71,25 @@ public void shouldAllowMixedValues() throws IllegalAccessException {
 	public void shouldFindFirstRecordByColumnValue() throws IllegalAccessException {
 		Employee record1 = employees.firstName.findFirst(NAME1);
 		assertEquals(1, record1.getPosition());
+
+		Employee record2 = employees.salary.findFirst(10000);
+		assertEquals(0, record2.getPosition());
+
+		Employee record3 = employees.salary.findFirst(12345);
+		assertNull(record3);
+	}
+
+	@Test
+	public void shouldFindAllRecordsByColumnValue() throws IllegalAccessException {
+		EmployeeView view1 = employees.firstName.findAll(NAME1);
+		assertEquals(1, view1.size());
+
+		EmployeeView view2 = employees.salary.findAll(10000);
+		assertEquals(2, view2.size());
+
+		EmployeeView view3 = employees.salary.findAll(12345);
+		assertEquals(0, view3.size());
 
-		Employee record2 = employees.salary.findFirst(20000);
-		assertEquals(2, record2.getPosition());
 	}
 
 }