Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect invalid RealmResults #1945

Closed
kneth opened this issue Dec 16, 2015 · 1 comment
Closed

Detect invalid RealmResults #1945

kneth opened this issue Dec 16, 2015 · 1 comment
Assignees
@beeender
Labels
T-Bug

Comments

@kneth
Copy link
Contributor

kneth commented Dec 16, 2015

The following code might lead to a native crash:

realm.beginTransaction();
RealmResults<Owner> owners = realm.allObjects(Owner.class);
RealmResults<Dog> dogs = owners.first().where().equalTo("dogs.name", "Fido").findAll();
owners.clear();
long nDogs = dogs.size(); // crash here
realm.commitTransaction();

The reason is that Realm's storage engine doesn't invalidate dogs after owners.clear(). Once it does, an exception should be thrown at dogs.size().

See also realm/realm-core#1413
@kneth kneth added T-Bug P1 Blocked This issue is blocked by another issue labels Dec 16, 2015
@kneth kneth mentioned this issue Dec 16, 2015
Closed
@zaki50 zaki50 mentioned this issue Dec 17, 2015
Closed
@cmelchior cmelchior mentioned this issue Dec 22, 2015
Closed
@MateuszGajowski MateuszGajowski mentioned this issue Dec 22, 2015
Closed
@beeender beeender self-assigned this Jan 19, 2016
beeender added a commit that referenced this issue Jan 22, 2016
@beeender
Access to RealmResults based on deleted RealmList
9cce188 
* When the original RealmList is deleted, for most methods of
  RealmResults should just work without crash by just treat it like an
  empty RealmResults.
* RealmResults.where() throws IllegalStateExecption in this case.
* RealmResults.isValid() return false in this case.

This is a temp fix, check realm/realm-core#1434
for more details.

Close #1945
@beeender beeender mentioned this issue Jan 22, 2016
Merged
beeender added a commit that referenced this issue Jan 22, 2016
@beeender
Access to RealmResults based on deleted RealmList
25d19ef 
* When the original RealmList is deleted, for most methods of
  RealmResults should just work without crash by just treat it like an
  empty RealmResults.
* RealmResults.where() throws IllegalStateExecption in this case.
* RealmResults.isValid() returns false in this case.

This is a temp fix, check realm/realm-core#1434
for more details.

Close #1945
beeender added a commit that referenced this issue Jan 25, 2016
@beeender
Access to RealmResults based on deleted RealmList
a14e4c0 
* When the original RealmList is deleted, for most methods of
  RealmResults should just work without crash by just treat it like an
  empty RealmResults.
* RealmResults.where() throws IllegalStateExecption in this case.
* RealmResults.isValid() returns false in this case.

This is a temp fix, check realm/realm-core#1434
for more details.

Close #1945
beeender added a commit that referenced this issue Jan 25, 2016
@beeender
Access to RealmResults based on deleted RealmList
26cbce8 
* When the original RealmList is deleted, for most methods of
  RealmResults should just work without crash by just treat it like an
  empty RealmResults.
* RealmResults.where() throws IllegalStateExecption in this case.
* RealmResults.isValid() returns false in this case.

This is a temp fix, check realm/realm-core#1434
for more details.

Close #1945
beeender added a commit that referenced this issue Jan 25, 2016
@beeender
Access to RealmResults based on deleted RealmList
dac387b 
* When the original RealmList is deleted, for most methods of
  RealmResults should just work without crash by just treat it like an
  empty RealmResults.
* RealmResults.where() throws IllegalStateExecption in this case.
* RealmResults.isValid() returns false in this case.

This is a temp fix, check realm/realm-core#1434
for more details.

Close #1945
@kneth kneth removed the Blocked This issue is blocked by another issue label Jan 25, 2016
@beeender
Copy link
Contributor

#2133 fixed this.

@beeender beeender removed the P1 label Jan 25, 2016
@beeender beeender mentioned this issue Jan 28, 2016
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@beeender beeender

Labels
T-Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beeender @kneth