Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let us hide the "lib" in com.tightdb.lib.Table #47

Closed
kspangsege opened this issue Aug 19, 2012 · 2 comments
Closed

Let us hide the "lib" in com.tightdb.lib.Table #47

kspangsege opened this issue Aug 19, 2012 · 2 comments

Comments

@kspangsege
Copy link
Contributor

I don't much like the "lib" part of

import com.tightdb.lib.Table;

First of all, the word "lib" does not really say anything that would help the customer understand why Table would be located there rather than in "com.tightdb". Secondly, I believe it is a very small change to eliminate it, since Table is the only class that the customer is likely to ever have to refer to in that package.

If we moved the Table annotation class to com.tightdb, the customer could simply write

import com.tightdb.*;

For now he needs at least

import com.tightdb.*;
import com.tightdb.lib.Table;

Another improvement (though less attractive in my opinion) would be to move Table to "com.tightdb.annotations", it seems that convention is fairly widespread:

import com.tightdb.*;
import com.tightdb.annotations.Table;
@ghost ghost assigned bmunkholm Aug 19, 2012
@bmunkholm
Copy link
Contributor

The last alternative is more verbose. I suggest to move it to com.tightdb.

@ghost ghost assigned nmihajlovski Aug 27, 2012
@bmunkholm
Copy link
Contributor

Maybe consider if all the highlevel should be under "com.tigthdb", and all the lowlevel under "com.tightdb.lowlevel"

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants