Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessarry code from the generator to decrease the JAR size #65

Closed
nmihajlovski opened this issue Nov 28, 2012 · 4 comments
Closed

Comments

@nmihajlovski
Copy link
Contributor

Some dependencies should be removed from the generator module, to decrease the total JAR size,

@ghost ghost assigned nmihajlovski Nov 28, 2012
@nmihajlovski
Copy link
Contributor Author

Removing the commons-io dependency from the generator might require several hours of work to implement proper file I/O manually (file search, file read, etc.), exposing a new risk of introducing new bugs, and over-complicating the code. It will make the produced JAR only 180 KB smaller. My opinion is that's not worth doing it, but what do you think?

@bmunkholm
Copy link
Contributor

It's only used in the generator, right?

On Fri, Nov 30, 2012 at 12:37 PM, Nikolche Mihajlovski <
notifications@github.com> wrote:

Removing the commons-io dependency from the generator might require
several hours of work to implement proper file I/O manually (file search,
file read, etc.), exposing a new risk of introducing new bugs, and
over-complicating the code. It will make the produced JAR only 180 KB
smaller. My opinion is that's not worth doing it, but what do you think?


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-10886337.

@nmihajlovski
Copy link
Contributor Author

Right, only in the generator.

@bmunkholm
Copy link
Contributor

Let's leave it for now, but keep it on the list for future enhancement.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants