make the TableBase insert* methods protected - should only be used by the lib.

[bmunkholm]

No description provided.

[nmihajlovski]

Those methods were removed as part of the issue #70.

[bmunkholm]

Ups - I think they should still be used. They are faster than the new
single line ones.

On Thu, Dec 20, 2012 at 7:22 PM, Nikolche Mihajlovski <
notifications@github.com> wrote:

Those methods were removed as part of the issue #70#70
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/71#issuecomment-11584620.

[nmihajlovski]

Hmm, it's not possible to make them protected without changing the design, because AbstractTable needs these methods to be public, to be able to call them. So, if the methods are protected, we need to call them from the same package, or from a sub-class of Table.

Another option is to construct some delegator object in the Table class, and put the insertXXX methods in the delegator, but the delegator will need a way to be exposed outside of the table (e.g. public method again) - this solution will decrease the number of directly exposed methods, but it's makes the design more complicated.