Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Import API #489

Merged
merged 40 commits into from
Dec 19, 2014
Merged

JSON Import API #489

merged 40 commits into from
Dec 19, 2014

Conversation

cmelchior
Copy link
Contributor

API methods :

Realm.createObjectFromJson(Class realmObject, JSONObject json)
Realm.createAllFromJson(Class realmObject, JSONArray json)

Realm.createObjectFromJson(Class realmObject, String json)
Realm.createAllFromJson(Class realmObject, String json)

// Uses JsonReader for stream parsing. Only for API 11+
Realm.createObjectFromJson(Class realmObject, InputStream json);
Realm.createAllFromJson(Class realmObject, InputStream json);

A few comments:

  • Import using InputStream only works for API 11+. Methods are annotated as such.
  • JSON property names need to match java variabel names.
  • Import API does not work in standard Java. JSON is only supported from Java 7, and with a different API.
  • If import fails, everything up to that point is put in the database (if Realm.commitTransaction() is called). We need a Realm.rollback() to change this behavior.
  • functions like createOrUpdateFromJson() would be natural extensions but awaits primary key support.

@cmelchior
Bumped Gradle and Android build tools to 2.1 and 0.13
ae0a82e
@cmelchior
Basic JSON import of simple data types.
a636ce1
@cmelchior
Merge branch 'master' into cm-json-import-api
b03725f
@cmelchior
Added annotation processor project to global gradle settings.
2e512fa
@cmelchior
Fixed references to version.txt.
50e3e08
@cmelchior
Support for importing single object references.
f9bcd2b
@cmelchior
Support for importing RealmLists.
725e854
@cmelchior
Added support for importing lists of objects.
1ec4fb6
@cmelchior
Streamlined API methods. Added basic tests for ison streams.
88d4329
@cmelchior
Support for stream simple types added.
0c41a3e
@cmelchior
Support for json stream arrays.
420dfc0
@cmelchior
Support for null JSON values added.
e4d78e0
@cmelchior
Cleanup test json.
097e862
@cmelchior
Cleanup
9a6b36d
@cmelchior
Merge branch 'master' into cm-json-import-api
d054fae
@cmelchior
Added support for importing json array stream to Realm.
ee960fd
@cmelchior
Added unit test for objects saved despite exception.
69db602
@cmelchior
Merge branch 'cm-json-import-api' of https://github.com/cmelchior/rea…
d602d6b 
…lm-java into cm-json-import-api
@cmelchior
Added example project + unit tests for ignored properties.
c5a4b23
@cmelchior
Merge branch 'master' into cm-json-import-api
609d1e8 
Conflicts:
	realm/src/main/java/io/realm/Realm.java
emanuelez
emanuelez reviewed Oct 22, 2014
View reviewed changes
build.gradle
@@ -3,7 +3,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:0.12.2'
classpath 'com.android.tools.build:gradle:0.13.+'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change but this should be another PR

@cmelchior
Copy link
Contributor Author

Updated with fixes for comments + added file with notes about API.

@cmelchior
Copy link
Contributor Author

There is a unit test for it testing all data types with a null value, it defaults to the default value for that datatype. I have updated the JavaDoc for the Json methods so this is clarified.

bmunkholm
bmunkholm reviewed Dec 19, 2014
View reviewed changes
distribution/RealmJsonExample/app/build.gradle
}

dependencies {
compile 'io.realm:realm-android:0.75.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 0.76.0

bmunkholm
bmunkholm reviewed Dec 19, 2014
View reviewed changes
realm/src/androidTest/java/io/realm/RealmJsonTest.java
protected void setUp() throws Exception {
Realm.deleteRealmFile(getContext());
testRealm = Realm.getInstance(getContext());
testRealm.beginTransaction();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to delete objects when the file has been deleted.

bmunkholm
bmunkholm reviewed Dec 19, 2014
View reviewed changes
realm/src/androidTest/java/io/realm/RealmJsonTest.java
}

public void testImportStream_DateAsLong() throws IOException {
InputStream in = loadJsonFromAssets("date_as_long.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 5 lines are repeated through out the next many tests. Make a local method for that.

emanuelez added a commit that referenced this pull request Dec 19, 2014
@emanuelez
Merge pull request #489 from cmelchior/cm-json-import-api
f58c607 
JSON Import API
@emanuelez emanuelez merged commit f58c607 into realm:master Dec 19, 2014
@Hazer Hazer mentioned this pull request Dec 23, 2014
Closed
2 tasks
@Zhuinden Zhuinden mentioned this pull request Aug 29, 2016
Closed
@Zhuinden Zhuinden mentioned this pull request Sep 18, 2016
Closed
@Zhuinden Zhuinden mentioned this pull request Oct 12, 2016
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.