Enable SSL integration tests #5430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some features were missing which caused ssl tests failures. See https://github.com/realm/openssl-android/pull/2 Linking with pre-build openssl 1.0.2k-1. - Use a new Realm instead of using deleteRealm()
cmelchior
approved these changes
Oct 16, 2017
| # FIXME Read the openssl version from core when the core/sync release has that information. | ||
| set(openssl_VERSION "1.0.2k") | ||
| set(openssl_FILENAME "openssl-${openssl_build_TYPE}-${openssl_VERSION}-Android-${ANDROID_ABI}") | ||
| set(openssl_BUILD_NUMBER "1") |
Contributor
There was a problem hiding this comment.
Perhaps add a comment that this number should match https://github.com/realm/openssl-android/pull/2/files#diff-5e3269174d70512b79d0b874838be93fR1 ?
Contributor
Author
There was a problem hiding this comment.
for the next core release, this will be removed since core will ship a openssl lib. no need to download anymore.
nhachicha
approved these changes
Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/realm/openssl-android/pull/2
Linking with pre-build openssl 1.0.2k-1.