Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RealmProxy#toString() to print length information for binary field #6767

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

joxon
Copy link
Contributor

@joxon joxon commented Mar 5, 2020

Fixes #1650

@cmelchior
Copy link
Contributor

cmelchior commented Mar 5, 2020

Hi @joxon Thank you very much for adding this 👏 . The change itself looks fine, but it would be nice with a unit test as well to ensure that the functionality both works now and doesn't break in the future.

Also, it looks you already signed our CLA 👍

@bmunkholm
Copy link
Contributor

An update in the changelog.md would also be needed.

@joxon
Copy link
Contributor Author

joxon commented Mar 6, 2020

The change itself looks fine, but it would be nice with a unit test as well to ensure that the functionality both works now and doesn't break in the future.

Hi. I noticed there is an existing test case that could verify the correctness. Can I update that instead of writing new test case?

@bmunkholm
Copy link
Contributor

@joxon Absolutely! That would be perfect!

@joxon
Copy link
Contributor Author

joxon commented Mar 7, 2020

Okay, the test cases are done. How should I update the changelog.md?

@cmelchior
Copy link
Contributor

@joxon Thanks for doing this. I'll update the CHANGELOG you don't have to worry about it.

@cmelchior cmelchior merged commit 6b7b85c into realm:master Mar 16, 2020
@Raynor999
Copy link

NPE:

 field is ByteArray -> {
                            emitStatement("stringBuilder.append(\"binary(\" + field.length + \")\")")
                        }

#6767

Caused by: java.lang.NullPointerException: Attempt to get length of null array

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmProxy#toString() should print length information for binary field
4 participants