Fix incorrect HTTP headers and resetPassword args #7121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
requested review from
edualonso,
clementetb,
rorbech and
nhachicha
and removed request for
edualonso,
clementetb and
rorbech
edualonso
approved these changes
Sep 22, 2020
clementetb
approved these changes
Sep 22, 2020
rorbech
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Looks good - besides the obvious "how to test" the resetPassword method. Seems like there is not even an option to react on it in the server through ex. https://docs.mongodb.com/realm/triggers/authentication-triggers/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7117
Only partially closes #7116 . Even with the correct argument order we are still getting "Invalid token data", but this also happens on JS, so until proven otherwise I'm going with the assumption the problem is in either ObjectStore or on the server. I'm trying to verify if the endpoint we are hitting for resetPassword is correct in order to rule out OS, but this PR should be in a reviewable state nonetheless.