Fix inconsistent Mediator output #7617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
reviewed
Dec 17, 2021
| for (metadata in classesToValidate) { | ||
| // Sort classes to ensure deterministic output. This is relevant when e.g. using Gradle | ||
| // Remote Cache since the order is not guaranteed between OS and Java versions. | ||
| for (metadata in classesToValidate.toSortedSet(compareByDescending { it.qualifiedClassName.name })) { |
Contributor
There was a problem hiding this comment.
Any specific reason for sorting this with compareByDescending instead of just compareBy? Just makes it a bit annoying to read the expected output, but I guess we can then see it is actually affecting the output.
Contributor
Author
There was a problem hiding this comment.
Yes, I assume that the reason was that we could see it affect the output. Which it did, since it broke our unit test. But yes, sorting is otherwise arbitrary.
Properties seem to be processed in order from their class, which looks fine.
rorbech
approved these changes
Dec 17, 2021
runningcode
approved these changes
Dec 17, 2021
cmelchior
deleted the
cm/bug/deterministic-annotation-processor-output
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7615
Replaces #7616