Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "foo.h" to "foo.hpp" #77

Merged
merged 3 commits into from
May 1, 2013
Merged

Change "foo.h" to "foo.hpp" #77

merged 3 commits into from
May 1, 2013

Conversation

kspangsege
Copy link
Contributor

Note: Depends upon #76

Why?

Because this causes the right syntax highlighting mode to be selected in editors such as Emacs as well as in code browsers such as GitHub.

/cc @bmunkholm

@kspangsege
Change C++ header suffix from '.h' to '.hpp' since this selects the c…
4679762 
…orrect syntax highlighting mode in editors as well as in code browsers such as GitHub
@ghost ghost assigned bmunkholm Mar 23, 2013
@bmunkholm
Copy link
Contributor

+1 - pending review, timing of the concept in general

@kspangsege
Copy link
Contributor Author

What do you mean by "pending review, timing of the concept in general"?

Please note that this pull request is not about anything else than the
renaming of some header files.

On Mon, Mar 25, 2013 at 11:31 AM, bmunkholm notifications@github.comwrote:

+1 - pending review, timing of the concept in general

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/77#issuecomment-15386144
.

@bmunkholm
Copy link
Contributor

It does include all the string-changes.

On Mon, Mar 25, 2013 at 11:52 AM, Kristian Spangsege <
notifications@github.com> wrote:

What do you mean by "pending review, timing of the concept in general"?

Please note that this pull request is not about anything else than the
renaming of some header files.

On Mon, Mar 25, 2013 at 11:31 AM, bmunkholm notifications@github.comwrote:

+1 - pending review, timing of the concept in general

—
Reply to this email directly or view it on GitHub<
https://github.com/Tightdb/tightdb_java2/pull/77#issuecomment-15386144>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/77#issuecomment-15386907
.

@kspangsege
Copy link
Contributor Author

It does so only because it is stacked on top of those changes.

I made an effort to make this clear in my initial comment for this pull
request. Please let me know if you find that initial comment unclear.

On Mon, Mar 25, 2013 at 1:01 PM, bmunkholm notifications@github.com wrote:

It does include all the string-changes.

On Mon, Mar 25, 2013 at 11:52 AM, Kristian Spangsege <
notifications@github.com> wrote:

What do you mean by "pending review, timing of the concept in general"?

Please note that this pull request is not about anything else than the
renaming of some header files.

On Mon, Mar 25, 2013 at 11:31 AM, bmunkholm notifications@github.comwrote:

+1 - pending review, timing of the concept in general

—
Reply to this email directly or view it on GitHub<
https://github.com/Tightdb/tightdb_java2/pull/77#issuecomment-15386144>
.

—
Reply to this email directly or view it on GitHub<
https://github.com/Tightdb/tightdb_java2/pull/77#issuecomment-15386907>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/77#issuecomment-15389217
.

@kspangsege kspangsege mentioned this pull request Apr 15, 2013
Merged
@bmunkholm bmunkholm merged commit ce1b419 into master May 1, 2013
beeender added a commit that referenced this pull request Jun 3, 2016
@beeender
Squashed 'realm/realm-jni/object-store/' changes from 91c87e4..57ee591
2395585 
57ee591 Merge pull request #78 from realm/mar/weakrealmnotifier-leak
8685390 Merge pull request #77 from realm/mar/results-leak
e2112f8 Merge pull request #81 from realm/mar/core-always-static
332813f Avoid dumping all environment variables when building core without ASan enabled.
bef0a6e Build core as a static library when building it as a dependency.
6d22d28 Merge pull request #72 from realm/tg/core-1.0.0
08404d7 Express `Results`' asignment operators in terms of their equivalent constructors.
3e95226 Have `Results` default its copy constructor.
fc63c4f Merge pull request #76 from realm/mar/fix-building-tests-in-xcode
2a75edd Move `List`s defaulted constructors and assignment operators out of line.
30f1c83 Merge pull request #75 from realm/sk/android-fixes
702b8a3 Avoid leaking the runloop and source if WeakRealmNotifier is move-assigned.
65a748d Fix move-assigning to a `Results` that has a notifier to not leak the `Realm`, and moving from a `Results` to not result in a use-after-free.
7e99634 Fix building tests in Xcode.
385fe97 Make Realm::is_closed() work on read-only instances
7bb8a04 Fix for object store build issues on Android
d4feb7e Actually bump the core version
840c46f Upgrade to core 1.0.0 and update the file exception translation to match

git-subtree-dir: realm/realm-jni/object-store
git-subtree-split: 57ee591809916034f0b4d9db6ea225f711743674
@kuwapa kuwapa mentioned this pull request Mar 26, 2019
Closed
@vishnus1224 vishnus1224 mentioned this pull request May 13, 2020
Closed
@SimonSchubert SimonSchubert mentioned this pull request May 25, 2020
Closed
@MeinLieberScholli MeinLieberScholli mentioned this pull request Jul 15, 2020
Closed
This was referenced Aug 17, 2020
Closed
Closed
@0xMineGo800m 0xMineGo800m mentioned this pull request Dec 16, 2020
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 14, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bmunkholm bmunkholm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kspangsege @bmunkholm