BREAKING-CHANGES: insertLong(), insertString() etc, moved into public inner class + ColumnType enum renamed #97
Conversation
…nto inner class. The methods are still publicly avaible, but does not show up in autocompletion, unless you call the getter method in Table, that holds an instance of the inner class. Performance test added, to easily check if performance takes it hit. It does not
…ose and more java like e.g. ColumnType.ColumnTypeString is now ColumnType.STRING etc
…when setting index
| ColumnTypeDate(7), | ||
| ColumnTypeTable(5), | ||
| ColumnTypeMixed(6); | ||
| BOOLEAN(1), |
There was a problem hiding this comment.
We should consider to make the Enums with only first letter Uppercase, and the rest lowercase. That way, it's the same as you write in the typed interface.
There was a problem hiding this comment.
The thing is, Enums are constants in java. The convention is to use upper case. See:
http://docs.oracle.com/javase/tutorial/java/javaOO/enum.html
It's correct that it differs from the typed interface differs anyway. But the typed interface is a different animal and also supports simple types e.g. int and long instead of Integer and Long.
|
Before trying to push something to a branch, you need to pull the latest changes to that branch first. Otherwise it can't be merged automatically, and the differences looks huge. |
… for immutable. Internal methods instance renamed to internal
| @@ -0,0 +1,35 @@ | |||
| package com.tightdb.examples.quickbenchmark; | |||
There was a problem hiding this comment.
I suggest we move this to /experiment folder, since all under examples are distributed to customers.
It would also be good here to test the difference between add() and the local insert() methods.
|
+1 |
BREAKING-CHANGES: insertLong(), insertString() etc, moved into public inner class + ColumnType enum renamed
No description provided.