Add calls to flush_ui_queue for Hermes

realm · May 17, 2022 · 34c6d0e · 34c6d0e
1 parent 612095d
commit 34c6d0e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 12 deletions.
diff --git a/src/jsi/jsi_function.hpp b/src/jsi/jsi_function.hpp
@@ -26,33 +26,43 @@ namespace js {
 template <>
 inline JsiVal realmjsi::Function::call(JsiEnv env, const JsiFunc& function, size_t argc, const JsiVal arguments[])
 {
-    return env(function->call(env, env.args(arguments, argc), argc));
+    auto result = env(function->call(env, env.args(arguments, argc), argc));
+    flush_ui_queue();
+    return result;
 }
 
 template <>
 inline JsiVal realmjsi::Function::call(JsiEnv env, const JsiFunc& function, const JsiObj& this_object, size_t argc,
                                        const JsiVal arguments[])
 {
-    return env(function->callWithThis(env, this_object, env.args(arguments, argc), argc));
+    auto result = env(function->callWithThis(env, this_object, env.args(arguments, argc), argc));
+    flush_ui_queue();
+    return result;
 }
 
 template <>
 inline JsiVal realmjsi::Function::callback(JsiEnv env, const JsiFunc& function, size_t argc, const JsiVal arguments[])
 {
-    return env(function->call(env, env.args(arguments, argc), argc));
+    auto result = env(function->call(env, env.args(arguments, argc), argc));
+    flush_ui_queue();
+    return result;
 }
 template <>
 inline JsiVal realmjsi::Function::callback(JsiEnv env, const JsiFunc& function, const JsiObj& this_object,
                                            size_t argc, const JsiVal arguments[])
 {
-    return env(function->callWithThis(env, this_object, env.args(arguments, argc), argc));
+    auto result = env(function->callWithThis(env, this_object, env.args(arguments, argc), argc));
+    flush_ui_queue();
+    return result;
 }
 
 template <>
 inline JsiObj realmjsi::Function::construct(JsiEnv env, const JsiFunc& function, size_t argc,
                                             const JsiVal arguments[])
 {
-    return env(function->callAsConstructor(env, env.args(arguments, argc), argc).asObject(env));
+    auto result = env(function->callAsConstructor(env, env.args(arguments, argc), argc).asObject(env));
+    flush_ui_queue();
+    return result;
 }
 
 } // namespace js

diff --git a/src/jsi/jsi_init.cpp b/src/jsi/jsi_init.cpp
@@ -19,12 +19,6 @@
 
 #include "jsi_init.hpp"
 
-namespace realm {
-namespace js {
-std::function<void()> flush_ui_queue;
-} // namespace js
-} // namespace realm
-
 #if !REALM_ENABLE_SYNC
 #pragma comment(lib, "ws2_32.lib")
 #pragma comment(lib, "crypt32")
@@ -47,7 +41,7 @@ extern "C" void realm_jsi_init(fbjsi::Runtime& rt, fbjsi::Object& exports, std::
     auto name = realm_constructor.getProperty(env, "name").asString(env);
     exports.setProperty(env, std::move(name), std::move(realm_constructor));
     // Store the function used to flush React Native microtask queue
-    js::flush_ui_queue = flush_ui_queue;
+    realm::js::flush_ui_queue = flush_ui_queue;
 }
 
 extern "C" void realm_jsi_invalidate_caches()

diff --git a/src/jsi/jsi_init.hpp b/src/jsi/jsi_init.hpp
@@ -18,6 +18,14 @@
 
 #pragma once
 
+#include <functional>
+
+namespace realm {
+namespace js {
+std::function<void()> flush_ui_queue;
+} // namespace js
+} // namespace realm
+
 #include "jsi_string.hpp"
 #include "jsi_protected.hpp"
 #include "jsi_function.hpp"