Statically cache the String value of g_internal_field for a small per…

…formance gain
realm · Sep 5, 2022 · b80c02f · b80c02f
1 parent a3747c1
commit b80c02f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/jsi/jsi_class.hpp b/src/jsi/jsi_class.hpp
@@ -490,7 +490,9 @@ class ObjectWrap {
 
     static Internal* get_internal(JsiEnv env, const JsiObj& object)
     {
-        auto internal = object->getProperty(env, g_internal_field);
+        static const auto js_internal_field = fbjsi::String::createFromAscii(env, g_internal_field);
+
+        auto internal = object->getProperty(env, js_internal_field);
         if (internal.isUndefined()) {
             // In the case of a user opening a Realm with a class-based model,
             // the user defined constructor will get called before the "internal" property has been set.
@@ -663,7 +665,8 @@ class ObjectWrap {
 } // namespace realmjsi
 
 template <typename ClassType>
-class ObjectWrap<realmjsi::Types, ClassType> : public realm::js::realmjsi::ObjectWrap<ClassType> {};
+class ObjectWrap<realmjsi::Types, ClassType> : public realm::js::realmjsi::ObjectWrap<ClassType> {
+};
 
 template <realmjsi::ArgumentsMethodType F>
 fbjsi::Value wrap(fbjsi::Runtime& rt, const fbjsi::Value& thisVal, const fbjsi::Value* args, size_t count)