Skip to content

Commit

Permalink
Various JSI fixes to greenlight more tests (#4129)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kraenhansen
FFranck authored and kraenhansen committed Dec 21, 2021
1 parent 270ef8e commit f5356d9
Show file tree
Hide file tree
Showing 4 changed files with 78 additions and 22 deletions.
50 changes: 31 additions & 19 deletions src/jsi/jsi_class.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,21 @@ class ObjectWrap {
// Also, may need to suppress destruction.
inline static std::optional<JsiFunc> s_ctor;

// TODO / FF: Pass property name along in exception
static fbjsi::Value readonly_setter_callback(fbjsi::Runtime& env, const fbjsi::Value& thisVal,
const fbjsi::Value* args, size_t count)
{
throw fbjsi::JSError(env, "Cannot assign to read only property");
}

static JsiFunc create_constructor(JsiEnv env)
{
auto& s_type = get_class();

auto nativeFunc = !bool(s_type.constructor)
? fbjsi::Value()
: fbjsi::Function::createFromHostFunction(
env, propName(env, s_type.name), /* XXX paramCount */ 0,
env, propName(env, s_type.name), /* paramCount verified by callback */ 0,
[](fbjsi::Runtime& rt, const fbjsi::Value&, const fbjsi::Value* args,
size_t count) -> fbjsi::Value {
REALM_ASSERT_RELEASE(count >= 1);
Expand Down Expand Up @@ -279,12 +286,16 @@ class ObjectWrap {
if (prop.setter) {
desc.setProperty(env, "set", funcVal(env, "set_" + name, 1, prop.setter));
}
else {
desc.setProperty(env, "set", funcVal(env, "set_" + name, 0, ObjectWrap::readonly_setter_callback));
}
defineProperty(env, *s_ctor, name, desc);
}

for (auto&& [name, method] : s_type.static_methods) {
auto desc = fbjsi::Object(env);
desc.setProperty(env, "value", funcVal(env, name, /* XXX paramCount */ 0, method));
desc.setProperty(env, "value",
funcVal(env, name, /* paramCount must be verified by callback */ 0, method));
defineProperty(env, *s_ctor, name, desc);
}

Expand All @@ -298,12 +309,16 @@ class ObjectWrap {
if (prop.setter) {
desc.setProperty(env, "set", funcVal(env, "set_" + name, 1, prop.setter));
}
else {
desc.setProperty(env, "set", funcVal(env, "set_" + name, 0, ObjectWrap::readonly_setter_callback));
}
defineProperty(env, proto, name, desc);
}

for (auto&& [name, method] : s_type.methods) {
auto desc = fbjsi::Object(env);
desc.setProperty(env, "value", funcVal(env, name, /* XXX paramCount */ 0, method));
desc.setProperty(env, "value",
funcVal(env, name, /* paramCount must be verified by callback */ 0, method));
defineProperty(env, proto, name, desc);
}

Expand All @@ -327,9 +342,10 @@ class ObjectWrap {
// XXX Do we want to trap things like ownKeys() and getOwnPropertyDescriptors() to support for...in?
auto [getter, setter] = s_type.index_accessor;
auto desc = fbjsi::Object(env);
desc.setProperty(env, "value",
globalType(env, "Function")
.call(env, "getter", "setter", R"(
desc.setProperty(
env, "value",
globalType(env, "Function")
.call(env, "getter", "setter", R"(
const integerPattern = /^-?\d+$/;
function getIndex(prop) {
if (typeof prop === "string" && integerPattern.test(prop)) {
Expand Down Expand Up @@ -373,20 +389,19 @@ class ObjectWrap {
} else if (index < 0) {
// This mimics realm::js::validated_positive_index
throw new Error(`Index ${index} cannot be less than zero.`);
} else if (setter) {
return setter(target, index, value);
} else {
return false;
return setter(target, index, value);
}
}
}
return (obj) => new Proxy(obj, handler);
)")
.asObject(env)
.asFunction(env)
.call(env, funcVal(env, "getter", 0, getter), funcVal(env, "setter", 1, setter))
.asObject(env)
.asFunction(env));
.asObject(env)
.asFunction(env)
.call(env, funcVal(env, "getter", 0, getter),
funcVal(env, "setter", 1, setter ? setter : ObjectWrap::readonly_setter_callback))
.asObject(env)
.asFunction(env));
defineProperty(env, *s_ctor, "_proxyWrapper", desc);
}

Expand Down Expand Up @@ -537,13 +552,10 @@ class ObjectWrap {
if (!maybeConstructor) {
// 1.Check by name if the constructor is already created for this RealmObject
if (!schemaObjects.count(schemaName)) {

// 2.Create the constructor

// create the RealmObject function by name
// XXX May need to escape/sanitize schema.name to avoid code injection
// create an anonymous RealmObject function
auto schemaObjectConstructor = globalType(env, "Function")
.callAsConstructor(env, "return function " + schema.name + "() {}")
.callAsConstructor(env, "return function () {}")
.asObject(env)
.asFunction(env)
.call(env)
Expand Down
4 changes: 4 additions & 0 deletions src/jsi/jsi_types.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ class JsiWrap {
{
return &m_val;
}
const T* operator*() const
{
return &m_val;
}

/*implicit*/ operator const T&() const&
{
Expand Down
42 changes: 40 additions & 2 deletions src/jsi/jsi_value.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "jsi_string.hpp"
#include "jsi_types.hpp"
#include "realm/util/to_string.hpp"
//#include "node_buffer.hpp"

namespace realm {
Expand Down Expand Up @@ -166,7 +167,7 @@ inline bool realmjsi::Value::is_binary(JsiEnv env, const JsiVal& value)
template <>
inline bool realmjsi::Value::is_valid(const JsiVal& value)
{
return true; // XXX
return (*value) != nullptr;
}

template <>
Expand Down Expand Up @@ -229,7 +230,42 @@ inline JsiVal realmjsi::Value::from_uuid(JsiEnv env, const UUID& uuid)
template <>
inline bool realmjsi::Value::to_boolean(JsiEnv env, const JsiVal& value)
{
return value->getBool(); // XXX should do conversion.
if (value->isBool()) {
return value->getBool();
}

// boolean conversions as specified by
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean ...

// trivial conversions to false
if (value->isUndefined() || value->isNull()) {
return false;
}

if (value->isObject()) {
// not null, as checked above
return true;
}

if (value->isString()) {
// only the empty string is false
return value->toString(env).utf8(env) == "";
}

if (value->isNumber()) {
double const dblval = value->getNumber();
if (dblval == std::nan("")) {
return false;
}

// TODO: add tests for these -- specifcally the case of numerals 0 and -0
fbjsi::String const jsistringval = value->toString(env);
std::string const stringval = jsistringval.utf8(env);

return (stringval == "0" || stringval == "-0");
}

throw fbjsi::JSError(env, util::format("cannot convert type %1 to boolean", Value::typeof(env, value)));
}

template <>
Expand Down Expand Up @@ -288,6 +324,8 @@ inline OwnedBinaryData realmjsi::Value::to_binary(JsiEnv env, const JsiVal& valu
template <>
inline JsiObj realmjsi::Value::to_object(JsiEnv env, const JsiVal& value)
{
// specs: https://tc39.es/ecma262/#sec-toobject
// see to_date
return env(value->asObject(env)); // XXX convert?
}

Expand Down
4 changes: 3 additions & 1 deletion tests/js/list-tests.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ module.exports = {
obj.arrayCol = [{ doubleCol: 1 }, { doubleCol: 2 }];
TestCase.assertEqual(array.length, 2);

TestCase.assertThrowsContaining(() => (array.length = 0), "Cannot assign to read only property 'length'");
// TODO / FF: switch tests when property name can be passed along again
// TestCase.assertThrowsContaining(() => (array.length = 0), "Cannot assign to read only property 'length'");
TestCase.assertThrowsContaining(() => (array.length = 0), "Cannot assign to read only property");
});

TestCase.assertEqual(array.length, 2);
Expand Down

0 comments on commit f5356d9

Please sign in to comment.