Skip to content

Commit

Permalink
[10.20.0-beta.1] Bump version
Browse files Browse the repository at this point in the history
Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203)

* Removed 0xd3adc0d3

* Providing a "soft" landing for users running in legacy debugging mode

* Simplified index.js as we have react-native/index.js

* Removed some logging

* Adding a note to the CHANGELOG

* Stop integration testing in legacy debug mode

* Incorporated feedback

* Fixed the environment check 🤦‍♂️

* Removed all mentions of GCDWebServer

Prevent dangling objects on JSCRuntime destruction (#4228)

* WIP

* Refactored to a separate js_notifications.hpp

* Using the NotificationBucket throughout the codebase

* Adding a note to the changelog

* Fixed compiling on GCC

* Trigger garbage collection after every test

* Ensure s_tokens static gets initialized before use

Removed a bash only prepare command
  • Loading branch information
kraenhansen committed Apr 11, 2022
1 parent bdb5819 commit f867892
Show file tree
Hide file tree
Showing 74 changed files with 4,945 additions and 16,361 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,16 +222,6 @@ jobs:
MOCHA_REMOTE_EXIT_ON_ERROR: true
RETRIES: 5
RETRY_DELAY: 300000 # 5 min
- name: Run tests (${{matrix.platform.name}} / Chrome Debugging)
if: ${{ false }}
run: npm run test:${{matrix.platform.name}}:chrome --prefix integration-tests/environments/react-native
env:
MOCHA_REMOTE_CONTEXT: missingServer
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
HEADLESS_DEBUGGER: true
RETRIES: 5
RETRY_DELAY: 300000 # 5 min
react-native-android:
name: React Native on Android (${{ matrix.type }} using ${{ matrix.engine }})
runs-on: macos-latest
Expand Down Expand Up @@ -309,16 +299,3 @@ jobs:
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
SPAWN_LOGCAT: true
- name: Run tests (Android / Chrome Debugging)
if: ${{ false }}
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: 29
target: google_apis
script: npm run test:android:chrome --prefix integration-tests/environments/react-native
env:
MOCHA_REMOTE_CONTEXT: missingServer
MOCHA_REMOTE_REPORTER: mocha-github-actions-reporter
MOCHA_REMOTE_EXIT_ON_ERROR: true
HEADLESS_DEBUGGER: true
SPAWN_LOGCAT: true
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[submodule "vendor/GCDWebServer"]
path = vendor/GCDWebServer
url = https://github.com/swisspol/GCDWebServer.git
[submodule "docs/jsdoc-template"]
path = docs/jsdoc-template
url = https://github.com/realm/realm-jsdoc.git
Expand Down
22 changes: 21 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,23 @@ x.x.x Release notes (yyyy-MM-dd)
* Fixed an issue where some references were not updated from `Subscriptions` to `SubscriptionSet`. ([#4298](https://github.com/realm/realm-js/pull/4298))
* Submitting [analytics](https://github.com/realm/realm-js/blob/master/README.md#analytics) as a postinstall script.

10.20.0-beta.1 Release notes (2022-1-27)
=============================================================
### Notes
Based on Realm JS v10.12.0: See changelog below for details on enhancements and fixes introduced between this and the previous pre release (which was based on Realm JS v10.11.0).

### Breaking change
* Removed all code related to the legacy Chrome Debugger. Please use [Flipper](https://fbflipper.com/) as debugger.

### Enhancements
* None.

### Fixed
* Fixed "JSCRuntime destroyed with a dangling API object" assertion when reloading an app in debug mode while running with Hermes engine disabled. ([#4115](https://github.com/realm/realm-js/issues/4115), since 10.20.0-alpha.0)

### Internal
* Remove the previous implementation to the JavaScriptCore engine (in `src/jsc`).

10.12.0 Release notes (2022-1-24)
=============================================================
### Notes
Expand Down Expand Up @@ -136,7 +153,7 @@ Please note the following API changes from the `10.12.0-beta.1` release of Flexi

10.20.0-beta.0 Release notes (2021-12-21)
=============================================================

### Notes
Based on Realm JS v10.11.0: See changelog below for details on enhancements and fixes introduced between this and the previous pre release (which was based on Realm JS v10.10.1).

### Enhancements
Expand Down Expand Up @@ -199,6 +216,7 @@ const config = {

10.20.0-alpha.2 Release notes (2021-11-25)
=============================================================
### Notes
NOTE: DO NOT USE THIS RELEASE IN PRODUCTION!
NOTE: This is an early (alpha) release with Hermes/JSI support: We expect crashes and bugs.

Expand Down Expand Up @@ -327,6 +345,7 @@ Based on Realm JS v10.10.1: See changelog below for details on enhancements and

10.20.0-alpha.1 Release notes (2021-9-1)
=============================================================
### Notes
NOTE: DO NOT USE THIS RELEASE IN PRODUCTION!
NOTE: This is an early (alpha) release with Hermes/JSI support. Only iOS is supported and we expect crashes and bugs.

Expand Down Expand Up @@ -362,6 +381,7 @@ Based on Realm JS v10.8.0: See changelog below for details on enhancements and f

10.20.0-alpha.0 Release notes (2021-9-1)
=============================================================
### Notes
NOTE: DO NOT USE THIS RELEASE IN PRODUCTION!
NOTE: This is an early (alpha) release with Hermes/JSI support. Only iOS is supported and we expect crashes and bugs.

Expand Down
6 changes: 0 additions & 6 deletions Realm.xcworkspace/xcshareddata/Realm.xcscmblueprint
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"DVTSourceControlWorkspaceBlueprintIdentifierKey" : "5EE721F9-041C-4877-9E73-A925C9DB080A",
"DVTSourceControlWorkspaceBlueprintWorkingCopyPathsKey" : {
"40F53A12E4AE40C654358321B91166ABD3E910A6" : "realm-js\/",
"F6F96CA34C5878B0A9123C7C37855491A5E599DA" : "realm-js\/vendor\/GCDWebServer\/",
"8F3C415DA79CDA7D23734F285B95F9F9A3C0CB81" : "realm-js\/src\/object-store\/"
},
"DVTSourceControlWorkspaceBlueprintNameKey" : "Realm",
Expand All @@ -27,11 +26,6 @@
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryURLKey" : "https:\/\/github.com\/realm\/realm-object-store.git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositorySystemKey" : "com.apple.dt.Xcode.sourcecontrol.Git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryIdentifierKey" : "8F3C415DA79CDA7D23734F285B95F9F9A3C0CB81"
},
{
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryURLKey" : "https:\/\/github.com\/swisspol\/GCDWebServer.git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositorySystemKey" : "com.apple.dt.Xcode.sourcecontrol.Git",
"DVTSourceControlWorkspaceBlueprintRemoteRepositoryIdentifierKey" : "F6F96CA34C5878B0A9123C7C37855491A5E599DA"
}
]
}
2 changes: 0 additions & 2 deletions RealmJS.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,4 @@ Pod::Spec.new do |s|
s.vendored_frameworks = 'react-native/ios/realm-js-ios.xcframework'

s.dependency 'React'
# TODO: Ensure the same version of GCDWebServer is used for Android
# s.dependency 'GCDWebServer'
end
2 changes: 1 addition & 1 deletion dependencies.list
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PACKAGE_NAME=realm-js
VERSION=10.20.0-beta.0
VERSION=10.20.0-beta.1
REALM_CORE_VERSION=11.13.0
NAPI_VERSION=4
OPENSSL_VERSION=1.1.1g
Expand Down
3 changes: 3 additions & 0 deletions integration-tests/tests/.mocharc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@
"require": [
"ts-node/register/transpile-only",
"src/node/inject-globals.ts"
],
"node-option": [
"expose_gc"
]
}
7 changes: 7 additions & 0 deletions integration-tests/tests/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ import { testSkipIf, suiteSkipIf } from "./utils/skip-if";
global.describe.skipIf = suiteSkipIf;
global.it.skipIf = testSkipIf;

afterEach(() => {
// Trigger garbage collection after every test, if exposed by the environment.
if (typeof global.gc === "function") {
global.gc();
}
});

// Using `require` instead of `import` here to ensure the Mocha globals (including `skipIf`) are set

describe("Test Harness", () => {
Expand Down
4 changes: 4 additions & 0 deletions integration-tests/tests/src/typings.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ interface Global extends NodeJS.Global {
path: path;
environment: Environment;
require: Require;
/**
* The environment might expose a method to suggest a garbage collection.
*/
gc?: () => void;
}

declare const global: Global;
Expand Down
19 changes: 0 additions & 19 deletions lib/browser/.eslintrc.json

This file was deleted.

70 changes: 0 additions & 70 deletions lib/browser/app.js

This file was deleted.

32 changes: 0 additions & 32 deletions lib/browser/async-open-task.js

This file was deleted.

84 changes: 0 additions & 84 deletions lib/browser/base64.js

This file was deleted.

Loading

0 comments on commit f867892

Please sign in to comment.