Sync for Windows #1349
Merged
Sync for Windows #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
force-pushed
the
yg/windows-sync
branch
from
c97882b to
3ddf1ea
Compare
|
@fealebenpae Will you please add the outstanding tasks as "todo"? |
fealebenpae
force-pushed
the
yg/windows-sync
branch
from
96a008d to
f67228c
Compare
# Conflicts: # src/RealmJS.xcodeproj/project.pbxproj
|
This is generally blocked on https://github.com/realm/realm-object-store/issues/557, but we can release Sync for Windows support as a beta even with failing tests in Object Store. The last remaining blocker for this PR is running the sync tests on Windows - they expect a ROS instance but we have no way of running one on Windows. @kneth should we disable sync tests on Windows, or is there an easy way to run ROS on another machine and use that for tests? |
|
@fealebenpae Let's disable the sync tests for now. |
This makes it possible to build realm-js-private with the Visual Studio gyp generator
|
@fealebenpae We need to rebase this on |
# Conflicts: # binding.gyp # src/object-store
This reverts commit ffb0f84.
interprocess communication seems to be broken
fealebenpae
force-pushed
the
yg/windows-sync
branch
from
4fba7ce to
daa9c69
Compare
# Conflicts: # dependencies.list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.