Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest object store changes #24

Merged
merged 76 commits into from
Sep 28, 2015
Merged

Merge latest object store changes #24

merged 76 commits into from
Sep 28, 2015

Conversation

alazier
Copy link
Contributor

@alazier alazier commented Sep 28, 2015

Much faster to copy and destroy with no loss in lookup performance.
Switch to an abstract class rather than std::function in preparation for having
more kinds of notifications with different arguments for KVO.
Change schema verification to operate on a pair of Schema objects rather than a
Schema and a Group to eliminate some redundant work done, defer some of the
work done for migrations to within the migration block to avoid doing it
unnecessarily, and make passing in a custom schema in the Config when creating
a Realm entirely equivalent to calling update_schema() afterwards.
Throw if it's called on a read-only Realm and ensure the Realm is left in a
valid state regardless of the starting state.
@alazier
Copy link
Contributor Author

alazier commented Sep 28, 2015

Also updates to latest version of react-native

@appden
Copy link
Contributor

appden commented Sep 28, 2015

LGTM 👍

alazier added a commit that referenced this pull request Sep 28, 2015
Merge latest object store changes
@alazier alazier merged commit 7007a9a into master Sep 28, 2015
@alazier alazier deleted the tg-realm branch September 28, 2015 22:56
simonask pushed a commit that referenced this pull request Jun 14, 2016
fix for setting properties to objects from other realms
@pawellewandowski pawellewandowski mentioned this pull request Apr 14, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants