Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require of AbortController from window #3008

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #3005 by updating realm-network-transport and using this instead a bundled version.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Jun 29, 2020
@kraenhansen kraenhansen requested review from kneth and ironage June 29, 2020 11:26
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this!

Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kraenhansen kraenhansen merged commit 58b8761 into v10 Jun 30, 2020
@kraenhansen kraenhansen deleted the kh/v10/fix-electron-abort-controller branch June 30, 2020 07:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants