Throw exceptions when not inside a transaction #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +98,10 @@ namespace realm { | |||
| { | |||
| using Accessor = NativeAccessor<ValueType, ContextType>; | |||
|
|
|||
| if (!realm->is_in_transaction()) { | |||
| throw std::runtime_error("Can only set property values within a transaction."); | |||
There was a problem hiding this comment.
We should make a new exception type for mutating outside of an exception and throw this new exception type whenever this occurs.
|
This looks good 👍 We will want to define a new exception type for mutations outside of write transactions, as other platforms will need to catch this and possibly handle this specific cases anywhere we throw from the shared object store code. We don't need to do this right now but should do it before pushing our object store changes to the shared repo. |
|
Fixes #40 |
|
retest this please |
appden
added a commit
that referenced
this pull request
Oct 12, 2015
Throw exceptions when not inside a transaction
alazier
added a commit
that referenced
this pull request
Mar 2, 2016
Test contains can be used as a property name in the parser
Closed
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.