Support the Hermes JS engine through JSI #4536

kraenhansen · 2022-04-28T11:52:00Z

What, How & Why?

This concludes our initial implementation towards JSI, enabling support for the Hermes JS engine.

☑️ ToDos

📝 Changelog entry
📝 Compatibility label is updated or copied from previous entry
🚦 Tests
📱 Check the React Native/other sample apps work if necessary
📝 Public documentation PR created or is not necessary
💥 Breaking label has been applied or is not necessary

Rename namespaces in the JSI codebase to reflect that it doesn't just support Hermes (#4079) Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes. This closes RJS-1337. Fixing C++ lint error

Hermes: Fixing a couple of breaking tests (#4120) * Relaxing error message asserting tests * Fixing testListSubscriptSetters Catching missing libjsi.so as librealm.so loads (#4123) Updated RN peer dependency version (#4124) Fix classes not extending `Realm.Object` (#4125) * Fixing custom classes not extending Realm.Object * Adding a note to the changelog * Update CHANGELOG.md Co-authored-by: FFranck <franck.franck@mongodb.com> Co-authored-by: FFranck <franck.franck@mongodb.com> Fixed throwing "Illegal constructor" (#4128) Clarifying the get_internal early return Refixed throwing "Illegal constructor" Various JSI fixes to greenlight more tests (#4129) Flipper doesnt support inlined sourcemaps Return an existing s_ctor Testing with Hermes on CI (#4106) * Adding hermes as target branch for the integration tests workflow * Reading environment variable when enabling Hermes * Adding test app to watchable directories * Adding a hermes variant when testing React Native * Making the ccache engine specific * Moved react-native entry point to fix lint error * Attempt at fixing ReactTestAppTests * Update Podfile to work around the Catalyst issue Fixes for type conversions and minor cleanups (#4137)

Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203) * Removed 0xd3adc0d3 * Providing a "soft" landing for users running in legacy debugging mode * Simplified index.js as we have react-native/index.js * Removed some logging * Adding a note to the CHANGELOG * Stop integration testing in legacy debug mode * Incorporated feedback * Fixed the environment check 🤦‍♂️ * Removed all mentions of GCDWebServer Prevent dangling objects on JSCRuntime destruction (#4228) * WIP * Refactored to a separate js_notifications.hpp * Using the NotificationBucket throughout the codebase * Adding a note to the changelog * Fixed compiling on GCC * Trigger garbage collection after every test * Ensure s_tokens static gets initialized before use Removed a bash only prepare command

Adding changelog template Updated package-locks Copied up the change log

Hermes: Adding an index.native.js (#4461) * Ading an index.native.js to help bundlers * Adding a note to the changelog Update CMakeLists.txt to resolve "react-native" (#4466) * Update CMakeLists.txt to resolve "react-native" This enables end-users to build the iOS XCFramework locally from our npm package, if they need it built with the same version of Xcode as they're using to build their app. * Update CHANGELOG.md * Updating package-lock.json

* Create prototyped object instead of constructor call Recreated package-lock * Ran lint fix

kraenhansen · 2022-04-28T15:18:41Z

As with #4435:

Merging this even with the "Realm Web" integration tests pending: It's are pending download of the BaaS docker image, I've tried re-running it and tests are passing when ran locally.

* [10.20.0-alpha.0] PRE-RELEASE - DO NOT USE IN PRODUCTION * [10.20.0-alpha.1] Bump version * [10.20.0-alpha.2] Bump version Rename namespaces in the JSI codebase to reflect that it doesn't just support Hermes (#4079) Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes. This closes RJS-1337. Fixing C++ lint error * [10.20.0-beta.0] Bump version Hermes: Fixing a couple of breaking tests (#4120) * Relaxing error message asserting tests * Fixing testListSubscriptSetters Catching missing libjsi.so as librealm.so loads (#4123) Updated RN peer dependency version (#4124) Fix classes not extending `Realm.Object` (#4125) * Fixing custom classes not extending Realm.Object * Adding a note to the changelog * Update CHANGELOG.md Co-authored-by: FFranck <franck.franck@mongodb.com> Co-authored-by: FFranck <franck.franck@mongodb.com> Fixed throwing "Illegal constructor" (#4128) Clarifying the get_internal early return Refixed throwing "Illegal constructor" Various JSI fixes to greenlight more tests (#4129) Flipper doesnt support inlined sourcemaps Return an existing s_ctor Testing with Hermes on CI (#4106) * Adding hermes as target branch for the integration tests workflow * Reading environment variable when enabling Hermes * Adding test app to watchable directories * Adding a hermes variant when testing React Native * Making the ccache engine specific * Moved react-native entry point to fix lint error * Attempt at fixing ReactTestAppTests * Update Podfile to work around the Catalyst issue Fixes for type conversions and minor cleanups (#4137) * [10.20.0-beta.1] Bump version Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203) * Removed 0xd3adc0d3 * Providing a "soft" landing for users running in legacy debugging mode * Simplified index.js as we have react-native/index.js * Removed some logging * Adding a note to the CHANGELOG * Stop integration testing in legacy debug mode * Incorporated feedback * Fixed the environment check 🤦‍♂️ * Removed all mentions of GCDWebServer Prevent dangling objects on JSCRuntime destruction (#4228) * WIP * Refactored to a separate js_notifications.hpp * Using the NotificationBucket throughout the codebase * Adding a note to the changelog * Fixed compiling on GCC * Trigger garbage collection after every test * Ensure s_tokens static gets initialized before use Removed a bash only prepare command * [10.20.0-beta.2] Bump version Adding changelog template Updated package-locks Copied up the change log * [10.20.0-beta.3] Bump version * [10.20.0-beta.4] Bump version Hermes: Adding an index.native.js (#4461) * Ading an index.native.js to help bundlers * Adding a note to the changelog Update CMakeLists.txt to resolve "react-native" (#4466) * Update CMakeLists.txt to resolve "react-native" This enables end-users to build the iOS XCFramework locally from our npm package, if they need it built with the same version of Xcode as they're using to build their app. * Update CHANGELOG.md * Updating package-lock.json * Adding changelog template * [10.20.0-beta.5] Bump version * Adding changelog template * Rolling up relevant notes in changelog * Class models: `Realm.Object#constructor` for JSI / Hermes (#4435) * Create prototyped object instead of constructor call Recreated package-lock * Ran lint fix Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> Updated the merge

Squashed commit of the following: commit a3747c1 Author: Andrew Meyer <andrew.meyer@mongodb.com> Date: Wed Aug 31 14:19:18 2022 +0200 Fix TypeScript errors in @realm/react (#4847) Changes to class based models caused @realm/react to break. This addresses these changes. commit f75302f Author: Andrew Meyer <andrew.meyer@mongodb.com> Date: Wed Aug 31 11:54:08 2022 +0200 Quick lint fix (#4845) commit dcabed2 Author: Andrew Meyer <andrew.meyer@mongodb.com> Date: Tue Aug 30 14:35:11 2022 +0200 Prepare CHANGELOG commit 0a366fb Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Sat Jul 16 08:58:05 2022 +0200 Small fix for RN integration test app commit 343d668 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Mon Jul 11 16:44:29 2022 +0200 [11.0.0-rc.1] Bump version commit 6d6a71a Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Mon Jul 11 16:39:09 2022 +0200 Upgraded JSI header to React Native 0.69.1 commit cd813a4 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Thu Jul 7 12:16:52 2022 +0200 Adding changelog template commit 10682c2 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Thu Jul 7 11:51:25 2022 +0200 Removing realm-core and src sourcecode from the NPM bundle commit 399b5a1 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Thu Jul 7 09:32:14 2022 +0200 [11.0.0-rc.0] Bump version commit c984d1f Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Thu Jul 7 11:01:52 2022 +0200 Attempt fixing CI issue commit 8daa0b9 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Mon Jul 4 12:06:05 2022 +0200 Update README.md (#4645) commit f46c812 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Wed Jun 8 16:30:35 2022 +0200 Fixed CPP lint issues commit 0788430 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Wed Jun 8 16:12:11 2022 +0200 Fixed failing a test commit 5250743 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Tue May 17 12:19:46 2022 +0200 Add calls to flush_ui_queue for Hermes (#4579) Rearranged jsi_init Refactored flush of UI queue for JSI commit 2b9c8b4 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Wed Jun 8 16:08:55 2022 +0200 Avoid copying args (#4629) commit e1adfc7 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Tue Jun 7 16:52:03 2022 +0200 Rebuild package-lock.json Updating package-lock Rebuild package-lock.json commit 2251bd8 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Tue May 17 12:19:46 2022 +0200 Rearranged jsi_init commit d3cdd3c Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Fri Apr 29 12:45:26 2022 +0200 Class-based Models types (#4537) * Improving ClassModel type * Fixed changelog commit f02ad56 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Thu Apr 28 17:18:52 2022 +0200 Support the Hermes JS engine through JSI (#4536) * [10.20.0-alpha.0] PRE-RELEASE - DO NOT USE IN PRODUCTION * [10.20.0-alpha.1] Bump version * [10.20.0-alpha.2] Bump version Rename namespaces in the JSI codebase to reflect that it doesn't just support Hermes (#4079) Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes. This closes RJS-1337. Fixing C++ lint error * [10.20.0-beta.0] Bump version Hermes: Fixing a couple of breaking tests (#4120) * Relaxing error message asserting tests * Fixing testListSubscriptSetters Catching missing libjsi.so as librealm.so loads (#4123) Updated RN peer dependency version (#4124) Fix classes not extending `Realm.Object` (#4125) * Fixing custom classes not extending Realm.Object * Adding a note to the changelog * Update CHANGELOG.md Co-authored-by: FFranck <franck.franck@mongodb.com> Co-authored-by: FFranck <franck.franck@mongodb.com> Fixed throwing "Illegal constructor" (#4128) Clarifying the get_internal early return Refixed throwing "Illegal constructor" Various JSI fixes to greenlight more tests (#4129) Flipper doesnt support inlined sourcemaps Return an existing s_ctor Testing with Hermes on CI (#4106) * Adding hermes as target branch for the integration tests workflow * Reading environment variable when enabling Hermes * Adding test app to watchable directories * Adding a hermes variant when testing React Native * Making the ccache engine specific * Moved react-native entry point to fix lint error * Attempt at fixing ReactTestAppTests * Update Podfile to work around the Catalyst issue Fixes for type conversions and minor cleanups (#4137) * [10.20.0-beta.1] Bump version Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203) * Removed 0xd3adc0d3 * Providing a "soft" landing for users running in legacy debugging mode * Simplified index.js as we have react-native/index.js * Removed some logging * Adding a note to the CHANGELOG * Stop integration testing in legacy debug mode * Incorporated feedback * Fixed the environment check 🤦‍♂️ * Removed all mentions of GCDWebServer Prevent dangling objects on JSCRuntime destruction (#4228) * WIP * Refactored to a separate js_notifications.hpp * Using the NotificationBucket throughout the codebase * Adding a note to the changelog * Fixed compiling on GCC * Trigger garbage collection after every test * Ensure s_tokens static gets initialized before use Removed a bash only prepare command * [10.20.0-beta.2] Bump version Adding changelog template Updated package-locks Copied up the change log * [10.20.0-beta.3] Bump version * [10.20.0-beta.4] Bump version Hermes: Adding an index.native.js (#4461) * Ading an index.native.js to help bundlers * Adding a note to the changelog Update CMakeLists.txt to resolve "react-native" (#4466) * Update CMakeLists.txt to resolve "react-native" This enables end-users to build the iOS XCFramework locally from our npm package, if they need it built with the same version of Xcode as they're using to build their app. * Update CHANGELOG.md * Updating package-lock.json * Adding changelog template * [10.20.0-beta.5] Bump version * Adding changelog template * Rolling up relevant notes in changelog * Class models: `Realm.Object#constructor` for JSI / Hermes (#4435) * Create prototyped object instead of constructor call Recreated package-lock * Ran lint fix Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> Updated the merge commit 02d1149 Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Wed Mar 30 16:28:08 2022 +0200 Class models: `Realm.Object#constructor` (#4427) * Adding a cast to Value operator on ReturnType * Adding integration tests of class constructors * Made the test reporter print stack * Implemented Realm.Object constructor * Added node implementation and fixed legacy tests * Read from this.constructor instead of new.target * Fixing JSC implementation * Updating types and tests * Fixed Person and Dog constructors * Updated @realm/react useObject + useQuery * Updated types to fix an issue * Dead code removal * Updated tests to use default values * Making the insertion types a bit more loose * Adding documentation * Renamed realm_object_object * Made the constructor "values" required * Renamed "RealmInsertionModel" to "Unmanged" * Adding a note to the changelog * Apply suggestions to docstrings Co-authored-by: Kenneth Geisshirt <k@zigzak.net> * Add docstring of set_internal and get_internal * Expect 2 arguments on the C++ code as well Co-authored-by: Kenneth Geisshirt <k@zigzak.net> commit 18146be Author: Kræn Hansen <kraen.hansen@mongodb.com> Date: Wed Mar 16 12:03:46 2022 +0100 Class models: Enforce `extends Realm.Object` (#4417) * Throw if constructors doesn't extend Realm.Object * Updating existing tests to the breaking change. * Adding a note to the changelog Attempt at fixing Android build Fixed broken Android merge

RedBeard0531 and others added 12 commits April 28, 2022 13:46

[10.20.0-alpha.0] PRE-RELEASE - DO NOT USE IN PRODUCTION

76e2303

[10.20.0-alpha.1] Bump version

c10adf0

[10.20.0-beta.2] Bump version

30f65a8

Adding changelog template Updated package-locks Copied up the change log

[10.20.0-beta.3] Bump version

1decaab

Adding changelog template

40333a8

[10.20.0-beta.5] Bump version

3720688

Adding changelog template

238938a

Rolling up relevant notes in changelog

e84ad01

kraenhansen added the Breaking label Apr 28, 2022

kraenhansen self-assigned this Apr 28, 2022

cla-bot bot added the cla: yes label Apr 28, 2022

Class models: Realm.Object#constructor for JSI / Hermes (#4435)

29f8fbc

* Create prototyped object instead of constructor call Recreated package-lock * Ran lint fix

kraenhansen merged commit 5de6594 into v11 Apr 28, 2022

kraenhansen deleted the hermes branch April 28, 2022 15:18

takameyer mentioned this pull request Aug 30, 2022

Match types for User#callFunction implementation across platforms #4840

Merged

11 tasks

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support the Hermes JS engine through JSI #4536

Support the Hermes JS engine through JSI #4536

kraenhansen commented Apr 28, 2022

kraenhansen commented Apr 28, 2022

Support the Hermes JS engine through JSI #4536

Support the Hermes JS engine through JSI #4536

Conversation

kraenhansen commented Apr 28, 2022

What, How & Why?

☑️ ToDos

kraenhansen commented Apr 28, 2022