Support setting list items #46
Conversation
| } | ||
|
|
||
| size_t index = std::stol(indexStr); | ||
| if (index >= size) { |
There was a problem hiding this comment.
Should we handle negative indexes?
There was a problem hiding this comment.
Yes, but actually does the C++ check for that like it does in the case of the getters? If so, then I could just remove this check altogether.
There was a problem hiding this comment.
C++ does not handle negative indexes, nor does it do any error checking at the core level. The object store/shared_realm code should check all arguments but we are interacting with the link_view directly here which is at the core level. We could/should put this check in a method on the array class (but can do this later), but support for negative indexes should be done in our binding code.
There was a problem hiding this comment.
Based on our slack discussion, if we remove this check then ObjectArray should handle this for us?
|
Please rebase/merge master if you haven't already to see if my earlier change fixes the CI failures. |
This must have been accidentally copy-pasted from ObjectTests.js
Added a test and made other array tests syntactically consistent. Resolves #45
appden
force-pushed
the
sk-array-setter
branch
from
d58b24c to
6788cd6
Compare
It will still throw if unable to make the conversion. Fixes #51
| @@ -261,7 +261,7 @@ JSValueRef RealmCreateObject(JSContextRef ctx, JSObjectRef function, JSObjectRef | |||
|
|
|||
| bool update = false; | |||
| if (argumentCount == 3) { | |||
| update = RJSValidatedValueToBool(ctx, arguments[2]); | |||
There was a problem hiding this comment.
It's the same idea. If something expects a Boolean in JS, it never should throw just because you passed null or 0 or whatever. Minifiers often take advantage of that assumption to convert all false to 0, etc.
Turns out this API can return NaN without an exception. Also added tests to make sure these conversions either work or throw exceptions in the appropriate places.
|
👍 |
Fixes many list-related issues.
Remove an incorrect std::move()
* Update sync dependency * Bump version to 0.14.0-1 * Bump sync version for testing * Bump sync version
Fixes #45