Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush RN UI queue on Android #4725

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Flush RN UI queue on Android #4725

merged 4 commits into from
Jul 15, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jul 13, 2022

What, How & Why?

This makes the tests run (almost) reliably on Android. I get 5 failures but for seemingly unrelated reasons. Previously many of the roundtrip tests would fail at random.

Note: it seems that the JNI header generator default has changed jclass to jobject. I just went with it but I'm not sure if this might cause issues!

Fixes #4389 for Android (already fixed on iOS)

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jul 13, 2022
@tomduncalf tomduncalf force-pushed the td/android-flush-queue branch from ac67aa5 to 244a824 Compare July 14, 2022 11:25
@tomduncalf tomduncalf changed the title Td/android flush queue Flush RN UI queue on Android Jul 14, 2022
@tomduncalf tomduncalf marked this pull request as ready for review July 14, 2022 11:31
Tom Duncalf added 2 commits July 14, 2022 12:35
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say much about this code, but I tried the branch out and the tests run much better now.

Copy link

@fronck fronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomduncalf tomduncalf merged commit 7b9ee1c into master Jul 15, 2022
@tomduncalf tomduncalf deleted the td/android-flush-queue branch July 15, 2022 10:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants