-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated Methods: #4987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6daa9da
to
b89404e
Compare
kneth
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment only - ship it!
b89404e
to
9ca1699
Compare
* The following deprecated methods have been removed: * `Realm#automaticSyncConfiguration` * `Realm.Credentials#google` with `authCode` parameter (use `authObject`) * `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
9ca1699
to
698dc39
Compare
kraenhansen
reviewed
Oct 7, 2022
kraenhansen
reviewed
Oct 7, 2022
kraenhansen
reviewed
Oct 7, 2022
kraenhansen
reviewed
Oct 7, 2022
kraenhansen
reviewed
Oct 7, 2022
kraenhansen
reviewed
Oct 7, 2022
8a0dda3
to
429db0a
Compare
takameyer
commented
Oct 7, 2022
61deb68
to
b398768
Compare
Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
b398768
to
74eeefe
Compare
kraenhansen
added a commit
that referenced
this pull request
Oct 14, 2022
This removes the types for the overload that got removed with #4987
9 tasks
kraenhansen
added a commit
that referenced
this pull request
Oct 15, 2022
This removes the types for the overload that got removed with #4987
kraenhansen
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Remove Deprecated Methods: * The following deprecated methods have been removed: * `Realm#automaticSyncConfiguration` * `Realm.Credentials#google` with `authCode` parameter (use `authObject`) * `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
kraenhansen
added a commit
that referenced
this pull request
Oct 18, 2022
This removes the types for the overload that got removed with #4987
kraenhansen
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Remove Deprecated Methods: * The following deprecated methods have been removed: * `Realm#automaticSyncConfiguration` * `Realm.Credentials#google` with `authCode` parameter (use `authObject`) * `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
kraenhansen
added a commit
that referenced
this pull request
Oct 18, 2022
This removes the types for the overload that got removed with #4987
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Realm#automaticSyncConfiguration
*Realm.Credentials#google
withauthCode
parameter (useauthObject
)Realm#writeCopyTo
now only accepts an output Realm configuration as a parameter.This closes #4825 and #4831
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's: