Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Methods: #4987

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Remove Deprecated Methods: #4987

merged 2 commits into from
Oct 7, 2022

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Oct 6, 2022

What, How & Why?

  • The following deprecated methods have been removed: * Realm#automaticSyncConfiguration * Realm.Credentials#google with authCode parameter (use authObject)
  • Realm#writeCopyTo now only accepts an output Realm configuration as a parameter.

This closes #4825 and #4831

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Oct 6, 2022
@takameyer takameyer requested review from kneth and kraenhansen October 6, 2022 07:58
@takameyer takameyer force-pushed the andrew/deprecated-methods branch from 6daa9da to b89404e Compare October 6, 2022 13:37
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment only - ship it!

@takameyer takameyer force-pushed the andrew/deprecated-methods branch from b89404e to 9ca1699 Compare October 6, 2022 14:10
* The following deprecated methods have been removed:
    * `Realm#automaticSyncConfiguration`
    * `Realm.Credentials#google` with `authCode` parameter (use `authObject`)
* `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
@takameyer takameyer force-pushed the andrew/deprecated-methods branch from 9ca1699 to 698dc39 Compare October 7, 2022 06:16
@takameyer takameyer force-pushed the andrew/deprecated-methods branch from 8a0dda3 to 429db0a Compare October 7, 2022 08:35
@takameyer takameyer force-pushed the andrew/deprecated-methods branch 2 times, most recently from 61deb68 to b398768 Compare October 7, 2022 09:35
Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
@takameyer takameyer force-pushed the andrew/deprecated-methods branch from b398768 to 74eeefe Compare October 7, 2022 10:02
@takameyer takameyer merged commit 80b47e1 into v11 Oct 7, 2022
@takameyer takameyer deleted the andrew/deprecated-methods branch October 7, 2022 10:14
kraenhansen added a commit that referenced this pull request Oct 14, 2022
This removes the types for the overload that got removed with #4987
kraenhansen added a commit that referenced this pull request Oct 15, 2022
This removes the types for the overload that got removed with #4987
kraenhansen pushed a commit that referenced this pull request Oct 18, 2022
* Remove Deprecated Methods:

* The following deprecated methods have been removed:
    * `Realm#automaticSyncConfiguration`
    * `Realm.Credentials#google` with `authCode` parameter (use `authObject`)
* `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
kraenhansen added a commit that referenced this pull request Oct 18, 2022
This removes the types for the overload that got removed with #4987
kraenhansen pushed a commit that referenced this pull request Oct 18, 2022
* Remove Deprecated Methods:

* The following deprecated methods have been removed:
    * `Realm#automaticSyncConfiguration`
    * `Realm.Credentials#google` with `authCode` parameter (use `authObject`)
* `Realm#writeCopyTo` now only accepts an output Realm configuration as a parameter.
kraenhansen added a commit that referenced this pull request Oct 18, 2022
This removes the types for the overload that got removed with #4987
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants