Make sure you can't iterate a dictionary with forEach() #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobOscarGunnarsson
requested review from
takameyer,
kraenhansen and
elle-j
|
@JacobOscarGunnarsson Just a quick note. In PR descriptions, please link to the github issue rather than the jira issue. For one, this has the benefit of closing said issue when merged, and for another, the user that submitted this github issue will see that there is progress for it. |
JacobOscarGunnarsson
force-pushed
the
jg/dictionary_foreach
branch
from
42c515d to
fe19e4e
Compare
papafe
added a commit
that referenced
this pull request
Feb 24, 2023
* bindgen: Implement getAllSyncSessions (#5492) Ensure that Realm enums are accessible (#5484) Apply suggestions from code review [skip ci] Small corrections [skip ci] Added changelog and final corrections Stub add test to validate that foreach throws on a dictionary (#5467) Using `RealmInsertionModel` on `Results#update` Updated "react-native" dev dep to 0.71.0 Bumped lower bound on our RN peer dependency [bindgen] SDK packaging (#5466) Adding "prebuild" and configuring it (#5447) add synthetic private brand fields to TS wrappers for C++ classes, and fix found bug import bindings directly rather than through internal Stub work
kraenhansen
pushed a commit
that referenced
this pull request
Mar 1, 2023
kraenhansen
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should validate that the following issue is resolved in bindgen