-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Realm enums are accessible #5484
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f12a14
Ensure that enums are accessible
a7e9e98
use mocha more extensively, make tests more granular
94376c5
misspelling
62dbed8
use deep equals on enums
aa75ccf
remove unecessary object comparison, change equals to equal
33c3f45
change to deep.equals for consistency
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
//////////////////////////////////////////////////////////////////////////// | ||
// | ||
// Copyright 2023 Realm Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
//////////////////////////////////////////////////////////////////////////// | ||
|
||
import { expect } from "chai"; | ||
import { | ||
ConnectionState, | ||
NumericLogLevel, | ||
OpenRealmBehaviorType, | ||
OpenRealmTimeOutBehavior, | ||
SessionStopPolicy, | ||
} from "realm"; | ||
|
||
describe("Enums", function () { | ||
describe("ConnectionState", function () { | ||
it("is accessible", function () { | ||
expect(ConnectionState).to.be.an("object"); | ||
expect(ConnectionState).to.deep.equals({ | ||
Disconnected: "disconnected", | ||
Connecting: "connecting", | ||
Connected: "connected", | ||
}); | ||
}); | ||
}); | ||
describe("SessionStopPolicy", function () { | ||
it("is accessible", function () { | ||
expect(SessionStopPolicy).to.be.an("object"); | ||
expect(SessionStopPolicy).to.deep.equal({ | ||
AfterUpload: "after-upload", | ||
Immediately: "immediately", | ||
Never: "never", | ||
}); | ||
}); | ||
}); | ||
describe("OpenRealmBehaviorType", function () { | ||
it("is accessible", function () { | ||
expect(OpenRealmBehaviorType).to.be.an("object"); | ||
expect(OpenRealmBehaviorType).to.deep.equal({ | ||
DownloadBeforeOpen: "downloadBeforeOpen", | ||
OpenImmediately: "openImmediately", | ||
}); | ||
}); | ||
}); | ||
describe("OpenRealmTimeOutBehavior", function () { | ||
it("is accessible", function () { | ||
expect(OpenRealmTimeOutBehavior).to.be.an("object"); | ||
expect(OpenRealmTimeOutBehavior).to.deep.equal({ | ||
OpenLocalRealm: "openLocalRealm", | ||
ThrowException: "throwException", | ||
}); | ||
}); | ||
}); | ||
describe("NumericLogLevel", function () { | ||
it("is accessible", function () { | ||
expect(NumericLogLevel).to.be.an("object"); | ||
expect(NumericLogLevel).to.deep.equals({ | ||
"0": "All", | ||
"1": "Trace", | ||
"2": "Debug", | ||
"3": "Detail", | ||
"4": "Info", | ||
"5": "Warn", | ||
"6": "Error", | ||
"7": "Fatal", | ||
"8": "Off", | ||
All: 0, | ||
Trace: 1, | ||
Debug: 2, | ||
Detail: 3, | ||
Info: 4, | ||
Warn: 5, | ||
Error: 6, | ||
Fatal: 7, | ||
Off: 8, | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first line shouldn't be needed when you're doing deep equals to an object. Btw, does it still work with having the
s
at the end ofequal
? (I'd vote for where you're usingto.deep.equal()
) :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, most of these "to" "be" "equal/equals" are just meaningless syntactic sugar that does not change its behavior. So it could be
expect(NumericLogLevel).deep.equals
orexpect(NumericLogLevel).to.deep.equal
. I like both, I have generally been using the former for less use of this chaining but the latter does read nicer.