-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable recommended eslint-plugin-jsdoc
rules
#5779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/eslint-jsdoc
branch
from
June 20, 2023 14:21
360761c
to
3bb7189
Compare
kraenhansen
force-pushed
the
kh/eslint-jsdoc
branch
from
June 21, 2023 08:49
3bb7189
to
7dd247a
Compare
kraenhansen
force-pushed
the
kh/eslint-jsdoc
branch
from
June 21, 2023 12:52
0b81115
to
9dc9f99
Compare
kraenhansen
force-pushed
the
kh/eslint-jsdoc
branch
from
June 21, 2023 13:04
9dc9f99
to
8b23c43
Compare
takameyer
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .eslint.json
is broken in packages/realm
. Other than that, LGTM
I've filed an issue with the JSDocs plugin for some of the warnings introduced by merging this PR: gajus/eslint-plugin-jsdoc#1119 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This upgrades and enables recommended
eslint-plugin-jsdoc
rules.