Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable recommended eslint-plugin-jsdoc rules #5779

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This upgrades and enables recommended eslint-plugin-jsdoc rules.

@kraenhansen kraenhansen marked this pull request as ready for review June 21, 2023 12:14
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .eslint.json is broken in packages/realm. Other than that, LGTM

packages/realm/realm.node Outdated Show resolved Hide resolved
packages/realm/.eslintrc.json Outdated Show resolved Hide resolved
@kraenhansen kraenhansen merged commit 28a50dc into main Jun 21, 2023
@kraenhansen kraenhansen deleted the kh/eslint-jsdoc branch June 21, 2023 14:13
@kraenhansen
Copy link
Member Author

I've filed an issue with the JSDocs plugin for some of the warnings introduced by merging this PR: gajus/eslint-plugin-jsdoc#1119

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants