Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install tests to specify Ruby version #5808

Merged
merged 1 commit into from
May 12, 2023
Merged

Update install tests to specify Ruby version #5808

merged 1 commit into from
May 12, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

Due to facebook/react-native#36423 we need specify a Ruby version.

@kraenhansen kraenhansen self-assigned this May 11, 2023
@cla-bot cla-bot bot added the cla: yes label May 11, 2023
@kraenhansen
Copy link
Member Author

I triggered a run, which succeeded on all variants 🎉 https://github.com/realm/realm-js/actions/runs/4950952428

@kraenhansen kraenhansen requested review from takameyer and kneth May 12, 2023 09:24
takameyer
takameyer approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@kraenhansen kraenhansen merged commit 3b0c34c into main May 12, 2023
@kraenhansen kraenhansen deleted the kh/install-tests-with-ruby-version branch May 12, 2023 16:47
papafe added a commit that referenced this pull request May 17, 2023
@papafe
Merge branch 'main' into fp/minimal-fts
b2fad35 
* main:
  Pushing update to the package-lock.json
  Binding resolution refactored (#5802)
  Update install-test-react-native.yml (#5808)
  Add more testing of IN operator (#5809)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

@kneth kneth Awaiting requested review from kneth

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @takameyer