Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to the "BSON v6 upgrade" #6618

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Apr 15, 2024

What, How & Why?

  • Uses the rollup alias plugin to provide an exact path for the "bson" package, to avoiding a top-level await when bundling "bson" into the "realm-web" IIFE bundle.
  • Updates the realm-web-integration-tests to consume the "realm-web" ESM bundle.

@kraenhansen kraenhansen requested a review from elle-j April 15, 2024 21:32
@kraenhansen kraenhansen self-assigned this Apr 15, 2024
@cla-bot cla-bot bot added the cla: yes label Apr 15, 2024
@kraenhansen kraenhansen force-pushed the kh/bson-v6-suggestions branch from 65ead58 to 234ccc4 Compare April 15, 2024 21:37
@kraenhansen kraenhansen added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Apr 15, 2024
@kraenhansen kraenhansen changed the title Avoiding top-level await when bundling "bson" into the "realm-web" IIFE bundle Suggestions to the "BSON v6 upgrade" Apr 16, 2024
@kraenhansen kraenhansen merged commit 4683d69 into lj/bson-v6 Apr 17, 2024
29 of 34 checks passed
@kraenhansen kraenhansen deleted the kh/bson-v6-suggestions branch April 17, 2024 07:16
kraenhansen added a commit that referenced this pull request Apr 17, 2024
* Fixed a warning in the realm-web Rollup config

* Moved typescript and commonjs plugin down and stripping comments to lower IIFE bundle size

* Adding an alias for "bson" pointing to the .cjs bundle

* Upgrading ts-loader in the realm-web integration tests

* Updating tsconfigs in the realm web integration tests

* Using ESM when importing realm-web integration test files
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant