-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 12.10.0-rc.0 #6696
Merged
Merged
Prepare for 12.10.0-rc.0 #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
added
the
no-jira-ticket
Skip checking the PR title for Jira reference
label
May 31, 2024
elle-j
added a commit
that referenced
this pull request
Jun 12, 2024
Co-authored-by: elle-j <elle-j@users.noreply.github.com>
elle-j
added a commit
that referenced
this pull request
Jun 12, 2024
…pe (#6694) * Group schema normalization tests into suites. * Allow 'counter' in schema parser. * Test schema parser with 'counter'. * Add Counter class. * Implement creating a counter on Realm object. * Add implementation to Counter. * Expose Core's 'add_int()'. * Add object property getter. * Export types. * Test create and access via 'realm.create()' (input: nums and Counter). * Test create and access via 'realm.create()' (input: collections). * Test create and access via collection accessors. * Test updating the counter value. * Test updating the Realm object counter property. * Move common logic to shared functions. * Test updating the Realm object collection property. * Test returning different reference for each access. * Test throwing when updating by non-integer. * Change how a counter should be defined in the schema. We originally decided on using 'counter' as its own primitive type (defined e.g. "type: 'counter'"). We have updated this to now use a 'presentation' type (e.g. "type: 'int', presentation: 'counter'"). * Rename test property. * Add 'skips' to tests that await implementation. * Add 'presentations' to the stored sdk-specifc schema info. * Add 'isCreating' argument to object property setters to disallow certain operations for counter. * Test throwing when resetting via property setter. * Test throwing outside transaction. * Test throwing if setting regular int to counter. * Test throwing if invalidated object. * Extend 'Unmanaged' with Counter and allowing number. * Throw custom message if getting value on invalid object. * Implement 'Counter.set()'. * Disallow counter as mixed. * Test throwing if used as mixed. * Test filtering. * Fixing returning null if counter is null. * Remove support for collections of counters. * Test updating Realm object counter prop via UpdateMode. * Fix Unmanaged type for Counter. * Add Unmanaged RealmSet. * Update API docs. * Remove implicit coercion to number due to TS not supporting it. For reference on lack of TS support, see: microsoft/TypeScript#2361 * Test 'Realm.schema'. * Replace 'Object.defineProperty' with Symbols. * Add CHANGELOG entry. * Change default value in test to non-zero. * Test throwing when setting 'Counter.value' directly. * Make 'describe' test names lowercase. * List what is not supported onto the 'Counter' API docs. * Move 'expectCounter' to common file. * Remove link to API ref docs in CHANGELOG if doing RC release. * Refactor a test to use `map` instead of for-loop Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com> * Update error message from 'floating point' to 'decimal'. * [12.10.0-rc.0] Bump version (#6696) Co-authored-by: elle-j <elle-j@users.noreply.github.com> * Prepare for vNext (#6697) Co-authored-by: elle-j <elle-j@users.noreply.github.com> * Update formatting. * Update test variable name. * Add links in CHANGELOG. Co-authored-by: Kenneth Geisshirt <kenneth.geisshirt@mongodb.com> * Update API docs formatting. * Update initial value in test from 0 to 10. * Refactor similar tests into for-loop. * Point to Core v14.10.0. * Update Counter API docs. * Remove redundant comment. * Refactor logic allowing/disallowing setting a counter. * Update type name w/o abbreviation Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com> * Fix CHANGELOG after merge. --------- Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com> Co-authored-by: Yavor Georgiev <fealebenpae@users.noreply.github.com> Co-authored-by: elle-j <elle-j@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kenneth Geisshirt <kenneth.geisshirt@mongodb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An automated PR for next release.