-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser support (take 2) #6821
Draft
kraenhansen
wants to merge
11
commits into
main
Choose a base branch
from
kh/browser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Browser support (take 2) #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/wrapper-refactored
branch
2 times, most recently
from
August 12, 2024 12:05
23ebc3a
to
348ab11
Compare
kraenhansen
force-pushed
the
kh/browser
branch
from
August 12, 2024 20:35
0058237
to
7c236b7
Compare
kraenhansen
force-pushed
the
kh/browser
branch
from
August 16, 2024 14:44
7c236b7
to
c07b995
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The work in #5895 has rotted a bit and we want to ensure this gets merged.
One blocker of that was the need for a top-level await of the WASM native module, which we cannot export as our module is currently CommonJS (uses require statements, which doesn't support top-level await semantics).
As outlined in the original proposal for the top-level await language feature:
And until our SDK exports as ESM, I suggest we export a
ready
promise which must be awaited until interacting with the SDK on platforms which load the native module asynchronously.NOTE: This PR currently targets
kh/wrapper-refactored
(which in turn targetskh/avoid-circular-imports
) and need to be re-based once it's merged.NOTE: This also needs to #6820
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessary@realm/devdocs
if documentation changes are needed