Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to #6922 refactoring after_realm_open into exclude_from_icloud_backup #6927

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

For some reason (yet to be determined) referencing the "shared_realm.hpp" from our platform.hpp fails compilation for Node.js on Windows. Instead of sinking more time and effort into locating the root cause and solving it, I refactored the implementation in #6922 to avoid referencing the SharedRealm from platform.hpp.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary
  • 🔔 Mention @realm/devdocs if documentation changes are needed

@kraenhansen kraenhansen added the no-jira-ticket Skip checking the PR title for Jira reference label Nov 11, 2024
@kraenhansen kraenhansen self-assigned this Nov 11, 2024
@cla-bot cla-bot bot added the cla: yes label Nov 11, 2024
@kraenhansen kraenhansen force-pushed the kh/exclude-from-icloud-backup-followup branch from e4d7aca to a71f6e7 Compare November 12, 2024 09:50
Copy link
Contributor

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool! Pretty sure I heard some users mention to me that they have seen their data "sync" on Flutter as well and from what I can see it's probably also because of iCloud backup (though I think if data is stored in the application support path, that also lets you opt out).

MOCHA_REMOTE_GREP='icloud' npm run test:ios --workspace @realm/react-native-test-app-tests
```

In the command above, we're explicitly grepping for the icloud backup tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the command above, we're explicitly grepping for the icloud backup tests.
In the command above, we're explicitly grepping for the iCloud backup tests.

@kraenhansen kraenhansen merged commit 8c1142c into main Nov 12, 2024
34 checks passed
@kraenhansen kraenhansen deleted the kh/exclude-from-icloud-backup-followup branch November 12, 2024 10:51
@kraenhansen kraenhansen mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants