Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Realm JS in the main process #1049

Merged
merged 3 commits into from
Dec 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
- None

## Internals
- None
- Removed all use of Realm JS from the main process.
4 changes: 0 additions & 4 deletions configs/webpack.base.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const { CheckerPlugin } = require('awesome-typescript-loader');
const { resolve } = require('path');
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
const HardSourceWebpackPlugin = require('hard-source-webpack-plugin');
const nodeExternals = require('webpack-node-externals');
const webpack = require('webpack');
Expand Down Expand Up @@ -50,9 +49,6 @@ module.exports = (env, argv) => {
new webpack.NamedModulesPlugin(),
new webpack.HotModuleReplacementPlugin(),
] : [
new UglifyJsPlugin({
sourceMap: true,
}),
new SentryPlugin({
release: `${package.name}@${package.version}`,
include: './build',
Expand Down
2 changes: 2 additions & 0 deletions configs/webpack.main.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ module.exports = (env, argv) => {
plugins: [
// Prevent the windows from loading the UI components
new webpack.IgnorePlugin(/\/ui/, /\/src\/windows$/),
// Prevent the main bundle from requiring Realm JS, as this does not
new webpack.IgnorePlugin(/realm$/),
].concat(isDevelopment ? [
new Visualizer({
filename: './main.statistics.html',
Expand Down
Loading