Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit existing ObjectId from table view #1290

Merged
merged 5 commits into from
May 29, 2020
Merged

Edit existing ObjectId from table view #1290

merged 5 commits into from
May 29, 2020

Conversation

steffenagger
Copy link
Contributor

@steffenagger steffenagger commented May 20, 2020 •
edited
Loading

Edit existing ObjectId - for issue: #1251

@steffenagger steffenagger requested a review from kraenhansen May 20, 2020 12:47
kraenhansen
kraenhansen approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you share the database file you're using to test this?

@steffenagger
Copy link
Contributor Author

@kraenhansen I've updated the generate-all-types-realm npm script to include Indexed, Optional & Required ObjectId test data.

@steffenagger steffenagger changed the title Incorporate ObjectId in create/edit flows Edit existing ObjectId from table view May 25, 2020
@steffenagger steffenagger changed the title Edit existing ObjectId from table view Edit existing ObjectId from table view May 25, 2020
@steffenagger steffenagger marked this pull request as ready for review May 25, 2020 14:31
@steffenagger steffenagger requested a review from kraenhansen May 25, 2020 14:31
@steffenagger steffenagger merged commit 29d1ceb into mongodb-schema-property-types May 29, 2020
@steffenagger steffenagger deleted the sa/bson-object-id branch May 29, 2020 09:27
kraenhansen pushed a commit that referenced this pull request Jun 3, 2020
@steffenagger
Edit existing ObjectId from table view (#1290)
2643174 
* Bumped to realm to alpha.6

* Nvm uses node v10

* parser for ObjectId / Cell uses StringCell for ObjectId

* Avoid ever generating a new ObjectId in parser.

* Release notes updated
kraenhansen pushed a commit that referenced this pull request Jun 4, 2020
@steffenagger
Edit existing ObjectId from table view (#1290)
34ad782 
* Bumped to realm to alpha.6

* Nvm uses node v10

* parser for ObjectId / Cell uses StringCell for ObjectId

* Avoid ever generating a new ObjectId in parser.

* Release notes updated
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees

@steffenagger steffenagger

Labels
T-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffenagger @kraenhansen