Embedded Object support. #1298
Merged
Embedded Object support. #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Jun 3, 2020
kraenhansen
force-pushed
the
sa/bson-embedded-objects
branch
from
c6d1735 to
2ec8d08
Compare
kraenhansen
changed the base branch from
mongodb-schema-property-types
to
channel/mongodb
kraenhansen
approved these changes
Jun 3, 2020
kraenhansen
pushed a commit
that referenced
this pull request
Jun 4, 2020
* POC JSON value in table view * Ensure first selected schema is not system schema or embeded. * Filtering out embedded object classes & disallowing creation in GUI. * LeftSidebar sees embedded objects as SystemClass. * Disable 'Update reference' in context menu when embedded object. * Temporarily disable creation of embedded objects with custom message. * isEmbeddedType continued * Disable double click on objects cells contain embedded object * Disable "Add existing ClassName" from context menu, in embedded objects list. * Spelling * PR suggestions (simplified const & check back in-line)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded solution for beta.1 release.
This disables features allowing creation of embedded objects. Only listing & editing is supported in this 1st draft.
(
isEmbeddedTypeshould be seen as a temporary solution)