RSTUDIO-538: Switch to the sass library #1654
Conversation
gagik
changed the base branch from
channel/major-15
to
gagik/update-realm-version
| @@ -70,7 +70,7 @@ | |||
| top: -$spacer; | |||
|
|
|||
| &__Btn { | |||
| margin: 0 ($spacer / 4); | |||
| margin: 0 (calc($spacer / 4)); | |||
There was a problem hiding this comment.
Using calc makes this compute when evaluating the CSS rather than when compiling the SASS and adds verbosity. What's the context on these changes?
There was a problem hiding this comment.
It's related to this: https://sass-lang.com/documentation/breaking-changes/slash-div/
math.div may be a more equivalent change, it's just required imports.
Actually this let me notice that they have an automatic migrator, so I could run that and see what the output is
There was a problem hiding this comment.
sass does actually simplify calc expressions to a single number in most cases as well although it's a bit different from plain /
| @@ -70,7 +70,7 @@ | |||
| top: -$spacer; | |||
|
|
|||
| &__Btn { | |||
| margin: 0 ($spacer / 4); | |||
| margin: 0 ($spacer * 0.25); | |||
There was a problem hiding this comment.
Interestingly enough, this is what the sass migrator tool does for this: https://github.com/sass/migrator#readme. Seems like the way to go
@kraenhansen It is a lot less verbose now, what do you think?
Changes the deprecated
node-sassdependency and uses https://github.com/sass/migrator#readme to mitigate warnings from the migration, namely: https://sass-lang.com/documentation/breaking-changes/slash-div/Resolves #1652