Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mixpanel + signup modal dialog #225

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Oct 9, 2017

This fixes #159 and #212.

skaermbillede 2017-10-09 kl 20 27 41

skaermbillede 2017-10-09 kl 20 25 28

@kraenhansen kraenhansen merged commit 23bf291 into master Oct 9, 2017
@kraenhansen kraenhansen deleted the kh/mixpanel-user-prompt branch October 9, 2017 18:58
@bigfish24
Copy link
Contributor

@kraenhansen I would have preferred to be listed as a reviewer for this. The skip button needs to be removed as this shouldn't allow the use of the app until you enter your email.

@drshore
Copy link

drshore commented Oct 10, 2017

The copy that is being requested from marketing is:

Thanks for using Realm Studio!
Please enter your email to continue.
---enter email here---
[unchecked] Send me notifications about product updates.
Button: Let’s get started!

@kraenhansen
Copy link
Member Author

@bigfish24 okay sorry. Could we find a way to make sure that doesn't happen again? Perhaps you could add a comment on the issues that you would like to review the implementation for?

@kraenhansen kraenhansen restored the kh/mixpanel-user-prompt branch October 10, 2017 09:53
@bigfish24
Copy link
Contributor

No worries I will do so next time!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A user should be prompted for their email address
3 participants