Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Object Store #4813

Merged
merged 2 commits into from
Apr 3, 2017
Merged

update Object Store #4813

merged 2 commits into from
Apr 3, 2017

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Apr 3, 2017

fixes #4802 and #4768

@jpsim jpsim requested a review from tgoyne April 3, 2017 19:45
@bdash bdash added the S:Review label Apr 3, 2017
CHANGELOG.md Outdated
@@ -13,6 +13,8 @@ x.x.x Release notes (yyyy-MM-dd)
### Bugfixes

* Fix CocoaPods installation with static libraries and multiple platforms.
* Fix uncaught "Bad version number" exceptions when refreshing a Realm with no
notification registered blocks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these words are in the wrong order, and it's possible (although harder) to hit the problematic case even when using explicit notification blocks, so I'd just say something like "Fix uncaught "Bad version number" exceptions on the notification worker thread followed by deadlocks when Realms refresh".

@jpsim jpsim merged commit d7ef625 into master Apr 3, 2017
@jpsim jpsim deleted the jp-update-os branch April 3, 2017 23:19
@jpsim jpsim removed the S:Review label Apr 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad version number in Realm 2.5.0 (Swift)
3 participants