Make non-breaking changes to support arrays of primitives #5148
Conversation
tgoyne
force-pushed
the
tg/primitive-array-nonbreaking
branch
2 times, most recently
from
b4fa6a9 to
da75922
Compare
Realm/RLMProperty.mm
Outdated
| _type = RLMPropertyTypeArray; | ||
| _objectClassName = value.objectClassName; | ||
| if (_objectClassName) { | ||
| // FIXME: validate |
There was a problem hiding this comment.
Is this an existing FIXME that was moved around, or something new that should be addressed?
| @@ -161,7 +161,7 @@ - (void)testDynamicTypes { | |||
|
|
|||
| // verify properties | |||
| RLMRealm *dyrealm = [self realmWithTestPathAndSchema:nil]; | |||
| RLMResults *results = [dyrealm allObjects:AllTypesObject.className]; | |||
| RLMResults<RLMObject *> *results = [dyrealm allObjects:AllTypesObject.className]; | |||
There was a problem hiding this comment.
Are these changes required by this PR, or are they being made preemptively in advance of #5149?
There was a problem hiding this comment.
All of the tests build and pass with no changes to the tests other than updating what error message a few of the tests are looking for.
| @@ -82,13 +82,13 @@ class SwiftRecursingSchemaTestObject : RLMObject { | |||
| } | |||
|
|
|||
| class InitAppendsToArrayProperty : RLMObject { | |||
| @objc dynamic var propertyWithIllegalDefaultValue: RLMArray = { | |||
| @objc dynamic var propertyWithIllegalDefaultValue: RLMArray<SwiftIntObject> = { | |||
There was a problem hiding this comment.
Are these changes required by this PR, or are they being made preemptively in advance of #5149?
| @@ -80,7 +80,7 @@ extension Realm { | |||
| instance provides access to the old and new database schemas, the objects in the Realm, and provides functionality for | |||
| modifying the Realm during the migration. | |||
| */ | |||
| public final class Migration { | |||
| public struct Migration { | |||
There was a problem hiding this comment.
I assume that changing from class to struct doesn't in any way change how users interact with these types (i.e., it's not a breaking change)?
There was a problem hiding this comment.
I don't see any way for it to break anything, since they're immutable types which the user can't construct directly. Realm should maybe also be a struct but that would actually be a breaking change.
There was a problem hiding this comment.
Users can theoretically do stupid things like retroactively conforming Migration to a class-only protocol, but I don't think that's something we should worry about.
tgoyne
force-pushed
the
tg/primitive-array-nonbreaking
branch
from
da75922 to
c902e67
Compare
The custom failure messages actually made it harder to figure out what had gone wrong than the default message.
…between NSNumber and RLMArray
These are all immutable and cheap to copy, so there's no reason for them to be reference types.
tgoyne
force-pushed
the
tg/primitive-array-nonbreaking
branch
from
d95d98e to
25c62de
Compare
| @@ -114,7 +114,8 @@ + (instancetype)schemaForObjectClass:(Class)objectClass { | |||
| Class superClass = class_getSuperclass(cls); | |||
| NSArray *allProperties = @[]; | |||
| while (superClass && superClass != RLMObjectBase.class) { | |||
| allProperties = [[RLMObjectSchema propertiesForClass:cls isSwift:isSwift] arrayByAddingObjectsFromArray:allProperties]; | |||
| allProperties = [[RLMObjectSchema propertiesForClass:cls isSwift:isSwift] | |||
| arrayByAddingObjectsFromArray:allProperties]; | |||
Realm/RLMObjectSchema.mm
Outdated
| } | ||
|
|
||
| // Check to see if this optional property is an underlying storage property for a Swift lazy var. | ||
| // Managed lazy vars are't allowed. |
A bunch of individually not very interesting changes made to support arrays of primitives. Should have no functional changes other than some error messages being a bit different.
Pulls in realm/realm-object-store#464 (and so depends on that getting merged).