[WIP] Object Subscripting on cursors #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| TightdbType columnType = [_table getColumnType:colNdx]; | ||
|
|
||
| // TODO: Verify obj type |
There was a problem hiding this comment.
You can probably use verify_cellwhich is found in my object literal branch.
|
Please add documentation and update |
| [_table setBinary:(TightdbBinary *)obj inColumn:colNdx atRow:_ndx]; | ||
| break; | ||
| case tightdb_Table: | ||
| [_table setTable:(TightdbTable *)obj inColumn:colNdx atRow:_ndx]; |
There was a problem hiding this comment.
What happens here if the specified object is not a TightdbTable?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added initial support for Object Subscripting on cursors so we can play with the syntax.
It mainly need some more error checking. When we get support in the basic table methods for taking native obj-c types like NSData as values, it should be easy to transition it to using them directly.
One note about the cursor object in general. I noticed that it holds a TightdbTable reference (i.e. the obj.c object) rather than a direct TableRef. I wonder if that is needed? It is a bit of unneeded overhead to have to do everything through obj-c selectors if we could have used direct method calls.
@bmunkholm @mekjaer @kneth