Refactor parts of RLMQueryUtil to reduce template instantiations #7005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is to transform queries which have a constant value on the LHS and a keypath on the RHS into one with the keypath on the RHS when possible. This eliminates a large number of redundant template instantiations, reducing the library size a bit and improving the build time. It also happens to make some queries which previous threw an exception work. C++17 lets us replace some of the template metaprogramming with `if constexpr` making things a bit simpler. Exception throwing has been shuffled around to reduce the size of the exception handler tables, and a few things have been refactored to cut down on unneeded duplication due to tmeplating. In total this bumps about 100 kB off the macOS release binary and is a small net reduction in the amount of non-test code.
|
Test failures are unrelated; realm/realm-core#4234 fixed the one new one. |
jsflax
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is to transform queries which have a constant value on the LHS and a keypath on the RHS into one with the keypath on the RHS when possible. This eliminates a large number of redundant template instantiations, reducing the library size a bit and improving the build time. It also happens to make some queries which previous threw an exception work.
C++17 lets us replace some of the template metaprogramming with
if constexprmaking things a bit simpler.Exception throwing has been shuffled around to reduce the size of the exception handler tables, and a few things have been refactored to cut down on unneeded duplication due to tmeplating.
In total this bumps about 100 kB off the macOS release binary and is a small net reduction in the amount of non-test code.