Work around canImport(Combine) being broken in Xcode 13 #7401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There still seems to be issues with Combine and it doesn't seem related to armv7? ❌ /Applications/Xcode-13.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.0.sdk/System/Library/Frameworks/Combine.framework/Modules/Combine.swiftmodule/i386-apple-ios-simulator.swiftinterface:57:59: 'AnyCancellable' is only available in iOS 13.0 or newer |
|
Oh, right, i386 is effected too. It's 32-bit iOS specifically that doesn't have Combine, so both device and simulator need to exclude it. |
tgoyne
force-pushed
the
tg/xcode-13-ios
branch
from
1d45897 to
d34d6c0
Compare
Xcode 13 beta 3 added a swiftinterface file for armv7 Combine which makes canImport(Combine) return true, but the swiftinterface file doesn't actually compile (and no armv7 devices can run OS versions with Combine).
tgoyne
force-pushed
the
tg/xcode-13-ios
branch
from
d34d6c0 to
5fd321e
Compare
dianaafanador3
approved these changes
Aug 19, 2021
leemaguire
approved these changes
Aug 19, 2021
This was referenced Sep 23, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 13 beta 3 added a swiftinterface file for armv7 Combine which makes canImport(Combine) return true, but the swiftinterface file doesn't actually compile (and no armv7 devices can run OS versions with Combine). Work around this by replacing the
canImport(Combine)checks with a define we manually set when building for armv7.