New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalize google analytics UA code #52

Open

michalbcz opened this issue Nov 20, 2016 · 0 comments

Member

michalbcz commented Nov 20, 2016

because we don't want test and dev version to pollute production Google Analytics statistics

vire added a commit to vire/reality-plugin that referenced this issue


          refactor(analytics): GA analytics tracker from ENV variable, move ana…

cbddd88

…lytics logic into background pa

Based on process.env.NODE_ENV either GA_TRACKER_DEV or GA_TRACKER_PROD is loaded from .evn file.
Also moved the analytics from template appending mechanism to background page because of clashes
with host site GA. More details in SO answer
https://stackoverflow.com/questions/10285886/chrome-extension-adding-external-javascript-to-current-pages-html?answertab=active#tab-top

Closes realreality#52

vire added a commit to vire/reality-plugin that referenced this issue


          refactor(analytics): GA analytics tracker from ENV variable, move ana…

7c6b6c8

…lytics logic into background pa

Based on process.env.NODE_ENV either GA_TRACKER_DEV or GA_TRACKER_PROD is loaded from .evn file.
Also moved the analytics from template appending mechanism to background page because of clashes
with host site GA. More details in SO answer
https://stackoverflow.com/questions/10285886/chrome-extension-adding-external-javascript-to-current-pages-html?answertab=active#tab-top

Closes realreality#52

vire added a commit to vire/reality-plugin that referenced this issue


          refactor(analytics): GA analytics tracker from ENV variable, move ana…

45739d3

…lytics logic into background pa

Based on process.env.NODE_ENV either GA_TRACKER_DEV or GA_TRACKER_PROD is loaded from .evn file.
Also moved the analytics from template appending mechanism to background page because of clashes
with host site GA. More details in SO answer
https://stackoverflow.com/questions/10285886/chrome-extension-adding-external-javascript-to-current-pages-html?answertab=active#tab-top

Closes realreality#52

vire mentioned this issue

refactor(analytics): GA analytics tracker from ENV variable #84

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment