Gui: fix recursive selection notification

Fixes #557 Fixes #710
realthunder · Aug 28, 2024 · b50ff63 · b50ff63
1 parent 0dcd00b
commit b50ff63
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Gui/Selection.cpp b/src/Gui/Selection.cpp
@@ -519,7 +519,8 @@ void SelectionSingleton::notify(SelectionChanges &&Chng)
     Base::FlagToggler<bool> flag(Notifying);
     NotificationQueue.push_back(std::move(Chng));
     while(!NotificationQueue.empty()) {
-        const auto &msg = NotificationQueue.front();
+        auto msg = NotificationQueue.front();
+        NotificationQueue.pop_front();
         bool notify;
         switch(msg.Type) {
         case SelectionChanges::AddSelection:
@@ -548,7 +549,6 @@ void SelectionSingleton::notify(SelectionChanges &&Chng)
                 Base::Console().Warning("notify: Unexpected boost exception\n");
             }
         }
-        NotificationQueue.pop_front();
     }
     NotificationRecursion = 0;
 }