Add all read/write functions to the interceptors list

[cjappl]

Adds all read and write variants to the interceptors list

closes realtime-sanitizer/rtsan#28

[cjappl]

@davidtrevelyan I found a fix for the issues previously discussed in the comments. This code works as intended (and tests pass on docker ubuntu and my mac)

[davidtrevelyan]

Reverted because there were some strange test failures introduced for macOS Sonoma 14.3.1 - to be investigated!

[cjappl]

Alright, very weird stuff happening!

This is working for me on the commit in which this code was merged:

fd40d880d2ac (HEAD) Add all read/write functions to the interceptors list (#17)

> make -C ~/code/radsan_cjappl/ test
if [ ! -d /Users/topher/code/radsan_cjappl/build ]; then \
                mkdir -p /Users/topher/code/radsan_cjappl/build; \
        fi
if [ ! -f llvm-project/README.md ]; then \
                git submodule update --init --recursive; \
        fi
if [ ! -f /Users/topher/code/radsan_cjappl/build/CMakeCache.txt ]; then \
                cmake -G "${RADSAN_CMAKE_GENERATOR:-Unix Makefiles}" \
                -DCMAKE_BUILD_TYPE=Release \
                -DBUILD_SHARED_LIBS=ON \
                -DCOMPILER_RT_BUILD_SANITIZERS=ON \
                -DLLVM_ENABLE_PROJECTS="clang;compiler-rt" \
                -DLLVM_TARGETS_TO_BUILD=Native \
                -DCMAKE_C_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \
                -DCMAKE_CXX_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \
                -DSANITIZER_MIN_OSX_VERSION=${RADSAN_MIN_OSX_VERSION:-10.15} \
                -B /Users/topher/code/radsan_cjappl/build \
                ./llvm-project/llvm; \
        fi
cmake --build /Users/topher/code/radsan_cjappl/build --target check-radsan -j8
...
Testing Time: 7.64s
  Passed: 76

1 warning(s) in tests

Here is any/all of the relevant information I can think of so we can compare our systems:

> sw_vers && clang --version
ProductName:            macOS
ProductVersion:         14.1.1
BuildVersion:           23B81
Apple clang version 15.0.0 (clang-1500.1.0.2.5)
Target: arm64-apple-darwin23.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I'll update to latest sonoma, but concerning if that is an issue that breaks it!!

[cjappl]

Still no failures with:

> sw_vers && clang --version
ProductName:            macOS
ProductVersion:         14.4
BuildVersion:           23E214
Apple clang version 15.0.0 (clang-1500.1.0.2.5)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Updating xcode and running again, but I'll post that result in the AM

[cjappl]

Alright, tests are passing for me on latest MacOs and latest clang with xcode.

> sw_vers && clang --version
ProductName:            macOS
ProductVersion:         14.4
BuildVersion:           23E214
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Any more factors that could affect this that you can think of @davidtrevelyan ? My mac is an M1 chip, for the record. You may have to dig in more on your side because I'm unable to repro the test failure

[davidtrevelyan]

Argh - this one is going to require some deeper investigations! I just tried a totally fresh build with:

> make test

and got:

...

********************
FAIL: RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/15/17 (16 of 31)
******************** TEST 'RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/15/17' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/Users/david/Repositories/radsan/build/projects/compiler-rt/lib/radsan/tests/./Radsan-arm64-Test-RealtimeSanitizer-Unit-20178-15-17.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=17 GTEST_SHARD_INDEX=15 /Users/david/Repositories/radsan/build/projects/compiler-rt/lib/radsan/tests/./Radsan-arm64-Test
--

Script:
--
/Users/david/Repositories/radsan/build/projects/compiler-rt/lib/radsan/tests/./Radsan-arm64-Test --gtest_filter=FdFixture.writevDiesWhenRealtime
--
/Users/david/Repositories/radsan/llvm-project/compiler-rt/lib/radsan/tests/radsan_test_utilities.h:36: Failure
Death test: realtimeInvoke(std::forward<Function>(func))
    Result: died but not with expected error.
  Expected: contains regular expression "Real-time violation: intercepted call to real-time unsafe function `writev`"
Actual msg:
[  DEATH   ]

/Users/david/Repositories/radsan/llvm-project/compiler-rt/lib/radsan/tests/radsan_test_utilities.h:36
Death test: realtimeInvoke(std::forward<Function>(func))
    Result: died but not with expected error.
  Expected: contains regular expression "Real-time violation: intercepted call to real-time unsafe function `writev`"
Actual msg:
[  DEATH   ]


********************
********************
Failed Tests (6):
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/preadDiesWhenRealtime
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/pwriteDiesWhenRealtime
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/readDiesWhenRealtime
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/readvDiesWhenRealtime
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/writeDiesWhenRealtime
  RealtimeSanitizer-Unit :: ./Radsan-arm64-Test/FdFixture/writevDiesWhenRealtime


Testing Time: 2.00s
  Passed: 75
  Failed:  6

1 warning(s) in tests
make[4]: *** [projects/compiler-rt/test/radsan/CMakeFiles/check-radsan] Error 1
make[3]: *** [projects/compiler-rt/test/radsan/CMakeFiles/check-radsan.dir/all] Error 2
make[2]: *** [projects/compiler-rt/test/radsan/CMakeFiles/check-radsan.dir/rule] Error 2
make[1]: *** [check-radsan] Error 2
make: *** [test] Error 2

Here's my system info:

> sw_vers && clang --version
ProductName:		macOS
ProductVersion:		14.4
BuildVersion:		23E214
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Looks like the only differences are me using the Xcode command line tools and an M3 chip...

[cjappl]

Very weird. I just say let's punt for now, this doesn't have to be in the first draft of upstreaming and we have bigger fish to fry.

[cjappl]

Filed a trello so we don't lose track of it:

https://trello.com/c/rlJ1ws6b/74-add-all-read-write-variants-to-the-interceptors-list-https-githubcom-realtime-sanitizer-llvm-project-pull-17