[Sketch] Rtsan/intercept more apple locks sanitizer dense map #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrevelyan
commented
Oct 30, 2025
| void __rtsan::Context::RealtimePush() { realtime_depth_++; } | ||
| void __rtsan::Context::RealtimePush() { | ||
| __sanitizer::SpinMutexLock lock{&spin_mutex_}; | ||
| depths_[pthread_self()].realtime++; |
There was a problem hiding this comment.
Need to think about handling the case where depths_ would need to be resized and (potentially) allocate more memory
davidtrevelyan
commented
Oct 30, 2025
| ExpectBypassed(true); | ||
| } | ||
|
|
||
| TEST_F(TestRtsanContext, IsProbablyThreadSafe) { |
There was a problem hiding this comment.
I presume this test would almost certainly not be able to be kept. But you never know.
davidtrevelyan
commented
Oct 30, 2025
| return REAL(os_unfair_lock_lock)(lock); | ||
| } | ||
|
|
||
| INTERCEPTOR(void, os_unfair_lock_unlock, os_unfair_lock_t lock) { |
There was a problem hiding this comment.
This is the one that triggered infinite recursion previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a just a draft PR to show a possible approach to userspace TLS in RTSan, thereby avoiding recursion from
pthread_onceimplementations calling an intercepted function during__rtsan::Contextinitialisation.